From 0126620c194f25aa8ce2b5d5b8c02100cccf21f6 Mon Sep 17 00:00:00 2001 From: Ian Manske Date: Wed, 28 Feb 2024 16:28:33 +0000 Subject: [PATCH] Disable flaky network tests (#12010) # Description Ignores some network tests that sometimes fail in CI. E.g., in [11953](https://github.com/nushell/nushell/pull/11953#issuecomment-1962275863) and [11654](https://github.com/nushell/nushell/pull/11654#issuecomment-1968404551). --- crates/nu-command/tests/commands/network/http/get.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/crates/nu-command/tests/commands/network/http/get.rs b/crates/nu-command/tests/commands/network/http/get.rs index f7071ae55b..bb7a8a4661 100644 --- a/crates/nu-command/tests/commands/network/http/get.rs +++ b/crates/nu-command/tests/commands/network/http/get.rs @@ -243,26 +243,32 @@ fn http_get_redirect_mode_error() { // These tests require network access; they use badssl.com which is a Google-affiliated site for testing various SSL errors. // Revisit this if these tests prove to be flaky or unstable. +// +// These tests are flaky and cause CI to fail somewhat regularly. See PR #12010. #[test] +#[ignore = "unreliable test"] fn http_get_expired_cert_fails() { let actual = nu!("http get https://expired.badssl.com/"); assert!(actual.err.contains("network_failure")); } #[test] +#[ignore = "unreliable test"] fn http_get_expired_cert_override() { let actual = nu!("http get --insecure https://expired.badssl.com/"); assert!(actual.out.contains("")); } #[test] +#[ignore = "unreliable test"] fn http_get_self_signed_fails() { let actual = nu!("http get https://self-signed.badssl.com/"); assert!(actual.err.contains("network_failure")); } #[test] +#[ignore = "unreliable test"] fn http_get_self_signed_override() { let actual = nu!("http get --insecure https://self-signed.badssl.com/"); assert!(actual.out.contains(""));