From 279297425d127944864b5e20c327c472ef8174f4 Mon Sep 17 00:00:00 2001 From: WindSoilder Date: Wed, 17 Jul 2024 07:57:27 +0800 Subject: [PATCH] simplify code --- crates/nu-command/src/generators/generate.rs | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/crates/nu-command/src/generators/generate.rs b/crates/nu-command/src/generators/generate.rs index c1d2d48f49..9c61d0fa93 100644 --- a/crates/nu-command/src/generators/generate.rs +++ b/crates/nu-command/src/generators/generate.rs @@ -192,18 +192,13 @@ fn get_initial_state( Some(v) => Ok(v), None => { // the initial state shold be referred from signature - if signature.optional_positional.len() > 0 { - if let Some(v) = &signature.optional_positional[0].default_value { - Ok(v.clone()) - } else { - Err(ShellError::GenericError { - error: "The initial value is missing".to_string(), - msg: "Missing intial value".to_string(), - span: Some(span), - help: Some("Provide initial value to generate, or assigning default value to closure parameter".to_string()), - inner: vec![], - }) - } + if signature.optional_positional.len() > 0 + && signature.optional_positional[0].default_value.is_some() + { + Ok(signature.optional_positional[0] + .default_value + .clone() + .expect("Already checked default value")) } else { Err(ShellError::GenericError { error: "The initial value is missing".to_string(),