From 2ccbefe01ee99e50b05ed56d08515f95ad00983c Mon Sep 17 00:00:00 2001 From: Antoine Stevan <44101798+amtoine@users.noreply.github.com> Date: Wed, 1 Mar 2023 23:40:50 +0100 Subject: [PATCH] REFACTOR: move the standard library to a less-confusing place (#8265) # Description we've discussed a bit about the location of the standard library in the #standard-library channel of the discord server => **the previous location, `crates/nu-utils/src/sample_config/`, was a bit confusing** - is `std.nu` a config file, just as `default_config.nu` or `default_env.nu`? - what is this `tests.nu` file inside the `sample_config/`? in this PR, i propose moving the standard library to `crates/nu-utils/standard_library/` for a few reasons: - `std.nu` is not a config file, so it should not be next to config files in a `sample_config/` directory - `tests.nu` is confusing if mixed with other unrelated files - `crates/nu-utils/` appears to be a good place for the standard library as it is meant to be a tool for `nushell` - i thought it would be strange to have `std.nu` inside `crates/nu-utils/src/` as this directory is generally filled with `rust` files, right? these are the reasons why i choose to propose `crates/nu-utils/standard_library/` :yum: # User-Facing Changes the standard library is now used with ```bash use crates/nu-utils/standard_library/std.nu ``` and the tests are run with ```bash nu crates/nu-utils/standard_library/tests.nu ``` # Tests + Formatting ```bash $nothing ``` # After Submitting ```bash $nothing ``` --- crates/nu-utils/{src/sample_config => standard_library}/std.nu | 0 crates/nu-utils/{src/sample_config => standard_library}/tests.nu | 0 2 files changed, 0 insertions(+), 0 deletions(-) rename crates/nu-utils/{src/sample_config => standard_library}/std.nu (100%) rename crates/nu-utils/{src/sample_config => standard_library}/tests.nu (100%) diff --git a/crates/nu-utils/src/sample_config/std.nu b/crates/nu-utils/standard_library/std.nu similarity index 100% rename from crates/nu-utils/src/sample_config/std.nu rename to crates/nu-utils/standard_library/std.nu diff --git a/crates/nu-utils/src/sample_config/tests.nu b/crates/nu-utils/standard_library/tests.nu similarity index 100% rename from crates/nu-utils/src/sample_config/tests.nu rename to crates/nu-utils/standard_library/tests.nu