From 3a983bb5db6b980483c60405393643a5e8972686 Mon Sep 17 00:00:00 2001
From: nils-degroot <53556985+nils-degroot@users.noreply.github.com>
Date: Sun, 10 Mar 2024 20:14:21 +0100
Subject: [PATCH] Improve error message for `into sqlite` with empty records
 (#12149)

<!--
if this PR closes one or more issues, you can automatically link the PR
with
them by using one of the [*linking
keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword),
e.g.
- this PR should close #xxxx
- fixes #xxxx

you can also mention related issues, PRs or discussions!
-->

- fixes #12126

# Description
<!--
Thank you for improving Nushell. Please, check our [contributing
guide](../CONTRIBUTING.md) and talk to the core team before making major
changes.

Description of your pull request goes here. **Provide examples and/or
screenshots** if your changes affect the user experience.
-->

This pr improves the error message for issue #12126

# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->

# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to
check that you're using the standard code style
- `cargo test --workspace` to check that all tests pass (on Windows make
sure to [enable developer
mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))
- `cargo run -- -c "use std testing; testing run-tests --path
crates/nu-std"` to run the tests for the standard library

> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->

# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
---
 crates/nu-command/src/database/commands/into_sqlite.rs | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/crates/nu-command/src/database/commands/into_sqlite.rs b/crates/nu-command/src/database/commands/into_sqlite.rs
index 6a4ae6cf47..fb74753155 100644
--- a/crates/nu-command/src/database/commands/into_sqlite.rs
+++ b/crates/nu-command/src/database/commands/into_sqlite.rs
@@ -213,6 +213,16 @@ fn insert_in_transaction(
         Some(val) => val.as_record()?,
     };
 
+    if first_val.is_empty() {
+        Err(ShellError::GenericError {
+            error: "Failed to create table".into(),
+            msg: "Cannot create table without columns".to_string(),
+            span: Some(span),
+            help: None,
+            inner: vec![],
+        })?;
+    }
+
     let table_name = table.name().clone();
     let tx = table.try_init(first_val)?;