From 4174ff3f3ee006eab1eec9fe7682fddc6a398ad7 Mon Sep 17 00:00:00 2001
From: WindSoilder <WindSoilder@outlook.com>
Date: Mon, 22 Jul 2024 13:57:12 +0800
Subject: [PATCH] save: print to stderr for bytestream

---
 crates/nu-command/src/filesystem/save.rs |  6 ++-
 crates/nu-command/tests/commands/save.rs | 62 ++++++++++++++++++++++++
 2 files changed, 66 insertions(+), 2 deletions(-)

diff --git a/crates/nu-command/src/filesystem/save.rs b/crates/nu-command/src/filesystem/save.rs
index be5073ef20..619e7d0b2b 100644
--- a/crates/nu-command/src/filesystem/save.rs
+++ b/crates/nu-command/src/filesystem/save.rs
@@ -121,9 +121,11 @@ impl Command for Save {
                             } else {
                                 match stderr {
                                     ChildPipe::Pipe(mut pipe) => {
-                                        io::copy(&mut pipe, &mut io::sink())
+                                        io::copy(&mut pipe, &mut io::stderr())
+                                    }
+                                    ChildPipe::Tee(mut tee) => {
+                                        io::copy(&mut tee, &mut io::stderr())
                                     }
-                                    ChildPipe::Tee(mut tee) => io::copy(&mut tee, &mut io::sink()),
                                 }
                                 .err_span(span)?;
                             }
diff --git a/crates/nu-command/tests/commands/save.rs b/crates/nu-command/tests/commands/save.rs
index 8a2332afdf..79cfcab651 100644
--- a/crates/nu-command/tests/commands/save.rs
+++ b/crates/nu-command/tests/commands/save.rs
@@ -463,3 +463,65 @@ fn save_same_file_with_collect_and_filter() {
         assert_eq!("helloworld", actual.out);
     })
 }
+
+#[test]
+fn save_from_child_process_dont_sink_stderr() {
+    Playground::setup("save_test_22", |dirs, sandbox| {
+        sandbox.with_files(&[
+            Stub::FileWithContent("log.txt", "Old"),
+            Stub::FileWithContent("err.txt", "Old Err"),
+        ]);
+
+        let expected_file = dirs.test().join("log.txt");
+        let expected_stderr_file = dirs.test().join("err.txt");
+
+        let actual = nu!(
+            cwd: dirs.root(),
+            r#"
+            $env.FOO = " New";
+            $env.BAZ = " New Err";
+            do -i {nu -n -c 'nu --testbin echo_env FOO; nu --testbin echo_env_stderr BAZ'} | save -a -r save_test_22/log.txt"#,
+        );
+        assert_eq!(actual.err, " New Err\n");
+
+        let actual = file_contents(expected_file);
+        assert_eq!(actual, "Old New\n");
+
+        let actual = file_contents(expected_stderr_file);
+        assert_eq!(actual, "Old Err\n");
+    })
+}
+
+#[test]
+fn parent_redirection_doesnt_affect_save() {
+    Playground::setup("save_test_22", |dirs, sandbox| {
+        sandbox.with_files(&[
+            Stub::FileWithContent("log.txt", "Old"),
+            Stub::FileWithContent("err.txt", "Old Err"),
+        ]);
+
+        let expected_file = dirs.test().join("log.txt");
+        let expected_stderr_file = dirs.test().join("err.txt");
+
+        let actual = nu!(
+            cwd: dirs.root(),
+            r#"
+            $env.FOO = " New";
+            $env.BAZ = " New Err";
+            def test [] {
+                do -i {nu -n -c 'nu --testbin echo_env FOO; nu --testbin echo_env_stderr BAZ'} | save -a -r save_test_22/log.txt,
+            };
+            test e> empty_file"#
+        );
+        assert_eq!(actual.err, " New Err\n");
+
+        let actual = file_contents(expected_file);
+        assert_eq!(actual, "Old New\n");
+
+        let actual = file_contents(expected_stderr_file);
+        assert_eq!(actual, "Old Err\n");
+
+        let actual = file_contents(dirs.test().join("empty_file"));
+        assert_eq!(actual, "");
+    })
+}