From 4aa9a18c63e2b8245fa816019796f4c154732cdd Mon Sep 17 00:00:00 2001
From: Genna Wingert <wingertge@gmail.com>
Date: Sat, 5 Mar 2022 22:56:04 +0100
Subject: [PATCH] Allow save to accept a list of strings (#4743)

---
 crates/nu-command/src/filesystem/save.rs | 28 ++++++++++++++++++++++++
 crates/nu-command/tests/commands/save.rs | 18 +++++++++++++++
 2 files changed, 46 insertions(+)

diff --git a/crates/nu-command/src/filesystem/save.rs b/crates/nu-command/src/filesystem/save.rs
index 48d1074873..8f7dfcfa3a 100644
--- a/crates/nu-command/src/filesystem/save.rs
+++ b/crates/nu-command/src/filesystem/save.rs
@@ -105,6 +105,20 @@ impl Command for Save {
 
                     Ok(PipelineData::new(span))
                 }
+                Value::List { vals, .. } => {
+                    let val = vals
+                        .into_iter()
+                        .map(|it| it.as_string())
+                        .collect::<Result<Vec<String>, ShellError>>()?
+                        .join("\n")
+                        + "\n";
+
+                    if let Err(err) = file.write_all(val.as_bytes()) {
+                        return Err(ShellError::IOError(err.to_string()));
+                    }
+
+                    Ok(PipelineData::new(span))
+                }
                 v => Err(ShellError::UnsupportedInput(
                     format!("{:?} not supported", v.get_type()),
                     span,
@@ -126,6 +140,20 @@ impl Command for Save {
 
                     Ok(PipelineData::new(span))
                 }
+                Value::List { vals, .. } => {
+                    let val = vals
+                        .into_iter()
+                        .map(|it| it.as_string())
+                        .collect::<Result<Vec<String>, ShellError>>()?
+                        .join("\n")
+                        + "\n";
+
+                    if let Err(err) = file.write_all(val.as_bytes()) {
+                        return Err(ShellError::IOError(err.to_string()));
+                    }
+
+                    Ok(PipelineData::new(span))
+                }
                 v => Err(ShellError::UnsupportedInput(
                     format!("{:?} not supported", v.get_type()),
                     span,
diff --git a/crates/nu-command/tests/commands/save.rs b/crates/nu-command/tests/commands/save.rs
index 95f82c31c6..2d3f8790ec 100644
--- a/crates/nu-command/tests/commands/save.rs
+++ b/crates/nu-command/tests/commands/save.rs
@@ -49,6 +49,24 @@ fn writes_out_csv() {
     })
 }
 
+#[test]
+fn writes_out_list() {
+    Playground::setup("save_test_3", |dirs, sandbox| {
+        sandbox.with_files(vec![]);
+
+        let expected_file = dirs.test().join("list_sample.txt");
+
+        nu!(
+            cwd: dirs.root(),
+            r#"echo [a b c d] | save save_test_3/list_sample.txt"#,
+        );
+
+        let actual = file_contents(expected_file);
+        println!("{actual}");
+        assert_eq!(actual, "a\nb\nc\nd\n")
+    })
+}
+
 #[test]
 fn save_append_will_create_file_if_not_exists() {
     Playground::setup("save_test_3", |dirs, sandbox| {