Public/nushell
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Only run SharedCow::to_mut once

Browse Source 
Peeping at the `cargo asm` output that this can't be elided due to side
effects of the atomic reads, so lifting it manually should save us some
extra work.
This commit is contained in:
sholderbach 2024-08-02 23:38:43 +02:00
parent e62356f5ec
commit 4d81d367fe
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
crates/nu-command/src/filters/default.rs
View File

@ -102,12 +102,13 @@ fn default(
val: ref mut record, val: ref mut record,
.. ..
} => { } => {
if let Some(val) = record.to_mut().get_mut(&column.item) { let record = record.to_mut();
if let Some(val) = record.get_mut(&column.item) {
if matches!(val, Value::Nothing { .. }) { if matches!(val, Value::Nothing { .. }) {
*val = value.clone(); *val = value.clone();
} }
} else { } else {
record.to_mut().push(column.item.clone(), value.clone()); record.push(column.item.clone(), value.clone());
} }
item item