From 545697c0b20b58f13b8dfbbefa700e2dbd08d864 Mon Sep 17 00:00:00 2001
From: Antoine Stevan <44101798+amtoine@users.noreply.github.com>
Date: Wed, 12 Jul 2023 19:33:25 +0200
Subject: [PATCH] simplify the test for `let` core command (#9671)

related to
- follow-up of https://github.com/nushell/nushell/pull/9658
- addressed part of https://github.com/nushell/nushell/issues/8670

# Description
removes useless `cwd` and `pipeline()` from the tests of `let`.

# User-Facing Changes
# Tests + Formatting
# After Submitting
---
 crates/nu-command/tests/commands/let_.rs | 49 +++++-------------------
 1 file changed, 9 insertions(+), 40 deletions(-)

diff --git a/crates/nu-command/tests/commands/let_.rs b/crates/nu-command/tests/commands/let_.rs
index 363f1bfdf4..d0967f93da 100644
--- a/crates/nu-command/tests/commands/let_.rs
+++ b/crates/nu-command/tests/commands/let_.rs
@@ -2,12 +2,7 @@ use nu_test_support::{nu, pipeline};
 
 #[test]
 fn let_name_builtin_var() {
-    let actual = nu!(
-        cwd: ".", pipeline(
-        r#"
-        let in = 3
-        "#
-    ));
+    let actual = nu!("let in = 3");
 
     assert!(actual
         .err
@@ -16,60 +11,37 @@ fn let_name_builtin_var() {
 
 #[test]
 fn let_doesnt_mutate() {
-    let actual = nu!(
-        cwd: ".", pipeline(
-        r#"
-        let i = 3; $i = 4
-        "#
-    ));
+    let actual = nu!("let i = 3; $i = 4");
 
     assert!(actual.err.contains("immutable"));
 }
 
 #[test]
 fn let_takes_pipeline() {
-    let actual = nu!(
-        cwd: ".", pipeline(
-        r#"
-        let x = "hello world" | str length; print $x
-        "#
-    ));
+    let actual = nu!(r#"let x = "hello world" | str length; print $x"#);
 
     assert_eq!(actual.out, "11");
 }
 
 #[test]
 fn let_pipeline_allows_in() {
-    let actual = nu!(
-        cwd: ".", pipeline(
-        r#"
-        def foo [] { let x = $in | str length; print ($x + 10) }; "hello world" | foo
-        "#
-    ));
+    let actual =
+        nu!(r#"def foo [] { let x = $in | str length; print ($x + 10) }; "hello world" | foo"#);
 
     assert_eq!(actual.out, "21");
 }
 
 #[test]
 fn mut_takes_pipeline() {
-    let actual = nu!(
-        cwd: ".", pipeline(
-        r#"
-        mut x = "hello world" | str length; print $x
-        "#
-    ));
+    let actual = nu!(r#"mut x = "hello world" | str length; print $x"#);
 
     assert_eq!(actual.out, "11");
 }
 
 #[test]
 fn mut_pipeline_allows_in() {
-    let actual = nu!(
-        cwd: ".", pipeline(
-        r#"
-        def foo [] { mut x = $in | str length; print ($x + 10) }; "hello world" | foo
-        "#
-    ));
+    let actual =
+        nu!(r#"def foo [] { mut x = $in | str length; print ($x + 10) }; "hello world" | foo"#);
 
     assert_eq!(actual.out, "21");
 }
@@ -79,10 +51,7 @@ fn mut_pipeline_allows_in() {
 fn let_with_external_failed() {
     // FIXME: this test hasn't run successfully for a long time. We should
     // bring it back to life at some point.
-    let actual = nu!(
-        cwd: ".",
-        pipeline(r#"let x = nu --testbin outcome_err "aa"; echo fail"#)
-    );
+    let actual = nu!(r#"let x = nu --testbin outcome_err "aa"; echo fail"#);
 
     assert!(!actual.out.contains("fail"));
 }