Public/nushell
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove ptree dep from nu-command, remove associated feature. (#3741)

Browse Source 
Nothing used the `ptree` feature or optional dependency within
`nu-command` except to include it within the `version` output. This
may be related to when `nu-cli` also had a `ptree` feature, but
I'm not sure.

That leaves the code within `nu_plugin_tree` as the sole remaining
user of `ptree`, which is already covered by the feature `tree`
and included in the `version` output.
This commit is contained in:
Bruce Mitchener 2021-07-06 22:33:24 +07:00 committed by GitHub
parent d1df9b9e38
commit 651d425046
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/ISSUE_TEMPLATE/bug_report.md vendored
View File

@ -38,7 +38,7 @@ Run `version | pivot` and paste the output to show OS, features, etc.
│ 4 │ pkg_version │ 0.24.1 │ │ 4 │ pkg_version │ 0.24.1 │
│ 5 │ build_time │ 2020-12-18 09:54:09 │ │ 5 │ build_time │ 2020-12-18 09:54:09 │
│ 6 │ build_rust_channel │ release │ │ 6 │ build_rust_channel │ release │
│ 7 │ features │ ctrlc, default, directories, dirs, git, ichwh, ptree, rich-benchmark, │ │ 7 │ features │ ctrlc, default, directories, dirs, git, ichwh, rich-benchmark, │
│ │ │ rustyline, term, uuid, which, zip │ │ │ │ rustyline, term, uuid, which, zip │
╰───┴────────────────────┴───────────────────────────────────────────────────────────────────────╯ ╰───┴────────────────────┴───────────────────────────────────────────────────────────────────────╯
``` ```

1
Cargo.lock generated
View File

@ -3392,7 +3392,6 @@ dependencies = [
"parking_lot 0.11.1", "parking_lot 0.11.1",
"pin-utils", "pin-utils",
"polars", "polars",
"ptree",
"query_interface", "query_interface",
"quick-xml 0.22.0", "quick-xml 0.22.0",
"quickcheck", "quickcheck",

4
Cargo.toml
View File

@ -67,7 +67,6 @@ rstest = "0.10.0"
[features] [features]
ctrlc-support = ["nu-cli/ctrlc", "nu-command/ctrlc"] ctrlc-support = ["nu-cli/ctrlc", "nu-command/ctrlc"]
ptree-support = ["nu-command/ptree"]
rustyline-support = ["nu-cli/rustyline-support", "nu-command/rustyline-support"] rustyline-support = ["nu-cli/rustyline-support", "nu-command/rustyline-support"]
term-support = ["nu-command/term"] term-support = ["nu-command/term"]
uuid-support = ["nu-command/uuid_crate"] uuid-support = ["nu-command/uuid_crate"]
@ -96,7 +95,6 @@ extra = [
"binaryview", "binaryview",
"inc", "inc",
"tree", "tree",
"ptree-support",
"textview", "textview",
"clipboard-cli", "clipboard-cli",
"trash-support", "trash-support",
@ -111,7 +109,7 @@ extra = [
"query-json", "query-json",
] ]
wasi = ["inc", "match", "ptree-support", "match", "tree", "rustyline-support"] wasi = ["inc", "match", "match", "tree", "rustyline-support"]
# Stable (Default) # Stable (Default)
fetch = ["nu_plugin_fetch"] fetch = ["nu_plugin_fetch"]

1
crates/nu-command/Cargo.toml
View File

@ -66,7 +66,6 @@ num-format = { version="0.4.0", features=["with-num-bigint"] }
num-traits = "0.2.14" num-traits = "0.2.14"
parking_lot = "0.11.1" parking_lot = "0.11.1"
pin-utils = "0.1.0" pin-utils = "0.1.0"
ptree = { version="0.3.1", optional=true }
query_interface = "0.3.5" query_interface = "0.3.5"
quick-xml = "0.22" quick-xml = "0.22"
rand = "0.8" rand = "0.8"

5
crates/nu-command/src/commands/core_commands/version.rs
View File

@ -191,11 +191,6 @@ fn features_enabled() -> Vec<String> {
names.push("ctrlc".to_string()); names.push("ctrlc".to_string());
} }
#[cfg(feature = "ptree")]
{
names.push("ptree".to_string());
}
// #[cfg(feature = "rich-benchmark")] // #[cfg(feature = "rich-benchmark")]
// { // {
// names.push("rich-benchmark".to_string()); // names.push("rich-benchmark".to_string());