From 79e4d35f0178bdb565bcfd65c236fc761135cd1e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jakub=20=C5=BD=C3=A1dn=C3=ADk?= <kubouch@gmail.com>
Date: Sat, 26 Mar 2022 21:22:35 +0200
Subject: [PATCH] Remove is_private from $nu.scope.commands (#4979)

---
 crates/nu-command/src/system/run_external.rs | 4 ----
 crates/nu-engine/src/eval.rs                 | 6 ------
 crates/nu-protocol/src/engine/command.rs     | 5 -----
 3 files changed, 15 deletions(-)

diff --git a/crates/nu-command/src/system/run_external.rs b/crates/nu-command/src/system/run_external.rs
index e24a207b45..75b1fb99a4 100644
--- a/crates/nu-command/src/system/run_external.rs
+++ b/crates/nu-command/src/system/run_external.rs
@@ -30,10 +30,6 @@ impl Command for External {
         "Runs external command"
     }
 
-    fn is_private(&self) -> bool {
-        true
-    }
-
     fn signature(&self) -> nu_protocol::Signature {
         Signature::build(self.name())
             .switch("redirect-stdout", "redirect-stdout", None)
diff --git a/crates/nu-engine/src/eval.rs b/crates/nu-engine/src/eval.rs
index 3e0fd7ac2e..93c927475d 100644
--- a/crates/nu-engine/src/eval.rs
+++ b/crates/nu-engine/src/eval.rs
@@ -977,12 +977,6 @@ pub fn create_scope(
                 span,
             });
 
-            cols.push("is_private".to_string());
-            vals.push(Value::Bool {
-                val: decl.is_private(),
-                span,
-            });
-
             cols.push("is_builtin".to_string());
             // we can only be a is_builtin or is_custom, not both
             vals.push(Value::Bool {
diff --git a/crates/nu-protocol/src/engine/command.rs b/crates/nu-protocol/src/engine/command.rs
index 1a34ee2c0d..8a90405c8b 100644
--- a/crates/nu-protocol/src/engine/command.rs
+++ b/crates/nu-protocol/src/engine/command.rs
@@ -27,11 +27,6 @@ pub trait Command: Send + Sync + CommandClone {
         false
     }
 
-    // Commands that are not meant to be run by users
-    fn is_private(&self) -> bool {
-        false
-    }
-
     fn examples(&self) -> Vec<Example> {
         Vec::new()
     }