diff --git a/crates/nu-protocol/src/signature.rs b/crates/nu-protocol/src/signature.rs index 5476a07a94..391afa51ac 100644 --- a/crates/nu-protocol/src/signature.rs +++ b/crates/nu-protocol/src/signature.rs @@ -190,8 +190,8 @@ impl Signature { } /// Get list of the long-hand flags - pub fn get_names(&self) -> Vec { - self.named.iter().map(|f| f.long.clone()).collect() + pub fn get_names(&self) -> Vec<&str> { + self.named.iter().map(|f| f.long.as_str()).collect() } /// Checks if short or long are already present @@ -206,9 +206,9 @@ impl Signature { }); let name = { - let name = name.into(); + let name: String = name.into(); debug_assert!( - !self.get_names().contains(&name), + !self.get_names().contains(&name.as_str()), "There may be duplicate name flags, such as --help" ); name diff --git a/crates/nu-parser/tests/test_signature.rs b/crates/nu-protocol/tests/test_signature.rs similarity index 98% rename from crates/nu-parser/tests/test_signature.rs rename to crates/nu-protocol/tests/test_signature.rs index aba82b4d37..2516409f01 100644 --- a/crates/nu-parser/tests/test_signature.rs +++ b/crates/nu-protocol/tests/test_signature.rs @@ -1,4 +1,4 @@ -use nu_parser::{Flag, PositionalArg, Signature, SyntaxShape}; +use nu_protocol::{Flag, PositionalArg, Signature, SyntaxShape}; #[test] fn test_signature() {