From a6e1cb1bfcdb371d2307df3c350fe333901cf9e6 Mon Sep 17 00:00:00 2001
From: Tim 'Piepmatz' Hesse <git+github@cptpiepmatz.de>
Date: Mon, 10 Jun 2024 08:25:16 +0200
Subject: [PATCH] apply lossless conversion

---
 crates/nu-protocol/src/value/into_value.rs | 31 +++++++++++-----------
 1 file changed, 16 insertions(+), 15 deletions(-)

diff --git a/crates/nu-protocol/src/value/into_value.rs b/crates/nu-protocol/src/value/into_value.rs
index cdf8ce849f..84ae4ed0c0 100644
--- a/crates/nu-protocol/src/value/into_value.rs
+++ b/crates/nu-protocol/src/value/into_value.rs
@@ -54,17 +54,13 @@ where
 
 macro_rules! primitive_into_value {
     ($type:ty, $method:ident) => {
-        impl IntoValue for $type {
-            fn into_value(self, span: Span) -> Value {
-                Value::$method(self, span)
-            }
-        }
+        primitive_into_value!($type => $type, $method);
     };
 
-    ($type:ty as $as_type:ty, $method:ident) => {
+    ($type:ty => $as_type:ty, $method:ident) => {
         impl IntoValue for $type {
             fn into_value(self, span: Span) -> Value {
-                Value::$method(self as $as_type, span)
+                Value::$method(<$as_type>::from(self), span)
             }
         }
     };
@@ -72,18 +68,23 @@ macro_rules! primitive_into_value {
 
 primitive_into_value!(bool, bool);
 primitive_into_value!(char, string);
-primitive_into_value!(f32 as f64, float);
+primitive_into_value!(f32 => f64, float);
 primitive_into_value!(f64, float);
-primitive_into_value!(i8 as i64, int);
-primitive_into_value!(i16 as i64, int);
-primitive_into_value!(i32 as i64, int);
+primitive_into_value!(i8 => i64, int);
+primitive_into_value!(i16 => i64, int);
+primitive_into_value!(i32 => i64, int);
 primitive_into_value!(i64, int);
-primitive_into_value!(isize as i64, int);
-primitive_into_value!(u8 as i64, int);
-primitive_into_value!(u16 as i64, int);
-primitive_into_value!(u32 as i64, int);
+primitive_into_value!(u8 => i64, int);
+primitive_into_value!(u16 => i64, int);
+primitive_into_value!(u32 => i64, int);
 // u64 and usize may be truncated as Value only supports i64.
 
+impl IntoValue for isize {
+    fn into_value(self, span: Span) -> Value {
+        Value::int(self as i64, span)
+    }
+}
+
 impl IntoValue for () {
     fn into_value(self, span: Span) -> Value {
         Value::nothing(span)