Public/nushell
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

change todos from panic to error

Browse Source
This commit is contained in:
Devyn Cairns 2024-06-10 16:20:28 -07:00
parent 63d278a344
commit a836711a22
1 changed files with 29 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
crates/nu-engine/src/compile/mod.rs
View File

@ -263,9 +263,9 @@ fn compile_expression(
Expr::Int(i) => lit(builder, Literal::Int(*i)), Expr::Int(i) => lit(builder, Literal::Int(*i)),
Expr::Float(f) => lit(builder, Literal::Float(*f)), Expr::Float(f) => lit(builder, Literal::Float(*f)),
Expr::Binary(bin) => lit(builder, Literal::Binary(bin.as_slice().into())), Expr::Binary(bin) => lit(builder, Literal::Binary(bin.as_slice().into())),
Expr::Range(_) => todo!(), Expr::Range(_) => Err(CompileError::Todo("Range")),
Expr::Var(_) => todo!(), Expr::Var(_) => Err(CompileError::Todo("Var")),
Expr::VarDecl(_) => todo!(), Expr::VarDecl(_) => Err(CompileError::Todo("VarDecl")),
Expr::Call(call) => { Expr::Call(call) => {
// Ensure that out_reg contains the input value, because a call only uses one register // Ensure that out_reg contains the input value, because a call only uses one register
if let Some(in_reg) = in_reg { if let Some(in_reg) = in_reg {
@ -286,10 +286,10 @@ fn compile_expression(
compile_call(engine_state, builder, &call, redirect_modes, out_reg) compile_call(engine_state, builder, &call, redirect_modes, out_reg)
} }
Expr::ExternalCall(_, _) => todo!(), Expr::ExternalCall(_, _) => Err(CompileError::Todo("ExternalCall")),
Expr::Operator(_) => todo!(), Expr::Operator(_) => Err(CompileError::Todo("Operator")),
Expr::RowCondition(_) => todo!(), Expr::RowCondition(_) => Err(CompileError::Todo("RowCondition")),
Expr::UnaryNot(_) => todo!(), Expr::UnaryNot(_) => Err(CompileError::Todo("UnaryNot")),
Expr::BinaryOp(lhs, op, rhs) => { Expr::BinaryOp(lhs, op, rhs) => {
if let Expr::Operator(ref operator) = op.expr { if let Expr::Operator(ref operator) = op.expr {
compile_binary_op( compile_binary_op(
@ -316,18 +316,18 @@ fn compile_expression(
out_reg, out_reg,
) )
} }
Expr::Block(_) => todo!(), Expr::Block(_) => Err(CompileError::Todo("Block")),
Expr::Closure(_) => todo!(), Expr::Closure(_) => Err(CompileError::Todo("Closure")),
Expr::MatchBlock(_) => todo!(), Expr::MatchBlock(_) => Err(CompileError::Todo("MatchBlock")),
Expr::List(_) => todo!(), Expr::List(_) => Err(CompileError::Todo("List")),
Expr::Table(_) => todo!(), Expr::Table(_) => Err(CompileError::Todo("Table")),
Expr::Record(_) => todo!(), Expr::Record(_) => Err(CompileError::Todo("Record")),
Expr::Keyword(_) => todo!(), Expr::Keyword(_) => Err(CompileError::Todo("Keyword")),
Expr::ValueWithUnit(_) => todo!(), Expr::ValueWithUnit(_) => Err(CompileError::Todo("ValueWithUnit")),
Expr::DateTime(_) => todo!(), Expr::DateTime(_) => Err(CompileError::Todo("DateTime")),
Expr::Filepath(_, _) => todo!(), Expr::Filepath(_, _) => Err(CompileError::Todo("Filepath")),
Expr::Directory(_, _) => todo!(), Expr::Directory(_, _) => Err(CompileError::Todo("Directory")),
Expr::GlobPattern(_, _) => todo!(), Expr::GlobPattern(_, _) => Err(CompileError::Todo("GlobPattern")),
Expr::String(s) => lit(builder, Literal::String(s.as_str().into())), Expr::String(s) => lit(builder, Literal::String(s.as_str().into())),
Expr::RawString(rs) => lit(builder, Literal::RawString(rs.as_str().into())), Expr::RawString(rs) => lit(builder, Literal::RawString(rs.as_str().into())),
Expr::CellPath(path) => lit(builder, Literal::CellPath(Box::new(path.clone()))), Expr::CellPath(path) => lit(builder, Literal::CellPath(Box::new(path.clone()))),
@ -358,12 +358,12 @@ fn compile_expression(
} }
Ok(()) Ok(())
} }
Expr::ImportPattern(_) => todo!(), Expr::ImportPattern(_) => Err(CompileError::Todo("ImportPattern")),
Expr::Overlay(_) => todo!(), Expr::Overlay(_) => Err(CompileError::Todo("Overlay")),
Expr::Signature(_) => todo!(), Expr::Signature(_) => Err(CompileError::Todo("Signature")),
Expr::StringInterpolation(_) => todo!(), Expr::StringInterpolation(_) => Err(CompileError::Todo("StringInterpolation")),
Expr::Nothing => todo!(), Expr::Nothing => Err(CompileError::Todo("Nothing ")),
Expr::Garbage => todo!(), Expr::Garbage => Err(CompileError::Todo("Garbage ")),
} }
} }
@ -528,6 +528,7 @@ enum CompileError {
InvalidRedirectMode, InvalidRedirectMode,
Garbage, Garbage,
UnsupportedOperatorExpression, UnsupportedOperatorExpression,
Todo(&'static str),
} }
impl CompileError { impl CompileError {
@ -547,6 +548,9 @@ impl CompileError {
CompileError::UnsupportedOperatorExpression => { CompileError::UnsupportedOperatorExpression => {
format!("{ice}unsupported operator expression") format!("{ice}unsupported operator expression")
} }
CompileError::Todo(msg) => {
format!("{ice}TODO: {msg}")
}
}; };
ShellError::GenericError { ShellError::GenericError {
error: message, error: message,