Public/nushell
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

adjust comment

Browse Source
This commit is contained in:
Devyn Cairns 2024-07-09 03:40:04 -07:00
parent 323e2dbed9
commit abbab2ef90
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
crates/nu-engine/src/eval_ir.rs
View File

@ -973,6 +973,11 @@ fn find_named_var_id(sig: &Signature, name: &[u8], span: Span) -> Result<VarId,
n.long.as_bytes() == name n.long.as_bytes() == name
} else { } else {
// If the arg has no long name, then compare against its short name // If the arg has no long name, then compare against its short name
//
// One limitation here is that it effectively makes them share the same namespace,
// if only for args that don't have any long name defined. This probably isn't a
// problem in practice, but TODO it would probably be good to have a parser error
// forbidding a long arg and short arg from having the same name?
n.short n.short
.is_some_and(|s| s.encode_utf8(&mut [0; 4]).as_bytes() == name) .is_some_and(|s| s.encode_utf8(&mut [0; 4]).as_bytes() == name)
} }