From b004aacd691de4c5c976d430eb3a2387e6aec235 Mon Sep 17 00:00:00 2001 From: Nupur Agrawal <46920259+murex971@users.noreply.github.com> Date: Thu, 12 Jan 2023 18:31:40 +0530 Subject: [PATCH] Add search terms in random and expression categories (#7736) # Description Refers to: [5093](https://github.com/nushell/nushell/issues/5093) # Tests - [x] `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - [x] `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - [x] `cargo test --workspace` to check that all tests pass --- crates/nu-command/src/dataframe/expressions/alias.rs | 4 ++++ crates/nu-command/src/dataframe/expressions/arg_where.rs | 4 ++++ crates/nu-command/src/dataframe/expressions/as_nu.rs | 4 ++++ crates/nu-command/src/dataframe/expressions/col.rs | 4 ++++ crates/nu-command/src/dataframe/expressions/concat_str.rs | 4 ++++ crates/nu-command/src/dataframe/expressions/is_in.rs | 4 ++++ crates/nu-command/src/dataframe/expressions/lit.rs | 4 ++++ crates/nu-command/src/dataframe/expressions/otherwise.rs | 4 ++++ crates/nu-command/src/dataframe/expressions/quantile.rs | 4 ++++ crates/nu-command/src/dataframe/expressions/when.rs | 4 ++++ crates/nu-command/src/random/bool.rs | 4 ++++ crates/nu-command/src/random/chars.rs | 4 ++++ crates/nu-command/src/random/decimal.rs | 4 ++++ crates/nu-command/src/random/dice.rs | 4 ++++ crates/nu-command/src/random/integer.rs | 4 ++++ crates/nu-command/src/random/uuid.rs | 4 ++++ 16 files changed, 64 insertions(+) diff --git a/crates/nu-command/src/dataframe/expressions/alias.rs b/crates/nu-command/src/dataframe/expressions/alias.rs index 81d78d1590..59af9e2f67 100644 --- a/crates/nu-command/src/dataframe/expressions/alias.rs +++ b/crates/nu-command/src/dataframe/expressions/alias.rs @@ -59,6 +59,10 @@ impl Command for ExprAlias { }] } + fn search_terms(&self) -> Vec<&str> { + vec!["aka", "abbr", "otherwise"] + } + fn run( &self, engine_state: &EngineState, diff --git a/crates/nu-command/src/dataframe/expressions/arg_where.rs b/crates/nu-command/src/dataframe/expressions/arg_where.rs index 90f4d2b953..8b89f25991 100644 --- a/crates/nu-command/src/dataframe/expressions/arg_where.rs +++ b/crates/nu-command/src/dataframe/expressions/arg_where.rs @@ -43,6 +43,10 @@ impl Command for ExprArgWhere { }] } + fn search_terms(&self) -> Vec<&str> { + vec!["condition", "match", "if"] + } + fn run( &self, engine_state: &EngineState, diff --git a/crates/nu-command/src/dataframe/expressions/as_nu.rs b/crates/nu-command/src/dataframe/expressions/as_nu.rs index 287b409941..bca323f52a 100644 --- a/crates/nu-command/src/dataframe/expressions/as_nu.rs +++ b/crates/nu-command/src/dataframe/expressions/as_nu.rs @@ -37,6 +37,10 @@ impl Command for ExprAsNu { }] } + fn search_terms(&self) -> Vec<&str> { + vec!["convert", "conversion"] + } + fn run( &self, _engine_state: &EngineState, diff --git a/crates/nu-command/src/dataframe/expressions/col.rs b/crates/nu-command/src/dataframe/expressions/col.rs index 8066e8f0b8..323688275e 100644 --- a/crates/nu-command/src/dataframe/expressions/col.rs +++ b/crates/nu-command/src/dataframe/expressions/col.rs @@ -43,6 +43,10 @@ impl Command for ExprCol { }] } + fn search_terms(&self) -> Vec<&str> { + vec!["create"] + } + fn run( &self, engine_state: &EngineState, diff --git a/crates/nu-command/src/dataframe/expressions/concat_str.rs b/crates/nu-command/src/dataframe/expressions/concat_str.rs index 3f847a0cca..82a69b1928 100644 --- a/crates/nu-command/src/dataframe/expressions/concat_str.rs +++ b/crates/nu-command/src/dataframe/expressions/concat_str.rs @@ -69,6 +69,10 @@ impl Command for ExprConcatStr { }] } + fn search_terms(&self) -> Vec<&str> { + vec!["join", "connect", "update"] + } + fn run( &self, engine_state: &EngineState, diff --git a/crates/nu-command/src/dataframe/expressions/is_in.rs b/crates/nu-command/src/dataframe/expressions/is_in.rs index 9051b4aa23..e384874de0 100644 --- a/crates/nu-command/src/dataframe/expressions/is_in.rs +++ b/crates/nu-command/src/dataframe/expressions/is_in.rs @@ -65,6 +65,10 @@ impl Command for ExprIsIn { }] } + fn search_terms(&self) -> Vec<&str> { + vec!["check", "contained", "is-contain", "match"] + } + fn run( &self, engine_state: &EngineState, diff --git a/crates/nu-command/src/dataframe/expressions/lit.rs b/crates/nu-command/src/dataframe/expressions/lit.rs index 1468dc452b..c1ea604194 100644 --- a/crates/nu-command/src/dataframe/expressions/lit.rs +++ b/crates/nu-command/src/dataframe/expressions/lit.rs @@ -42,6 +42,10 @@ impl Command for ExprLit { }] } + fn search_terms(&self) -> Vec<&str> { + vec!["string", "literal", "expression"] + } + fn run( &self, engine_state: &EngineState, diff --git a/crates/nu-command/src/dataframe/expressions/otherwise.rs b/crates/nu-command/src/dataframe/expressions/otherwise.rs index 001838766a..d0466a6168 100644 --- a/crates/nu-command/src/dataframe/expressions/otherwise.rs +++ b/crates/nu-command/src/dataframe/expressions/otherwise.rs @@ -79,6 +79,10 @@ impl Command for ExprOtherwise { ] } + fn search_terms(&self) -> Vec<&str> { + vec!["condition", "else"] + } + fn run( &self, engine_state: &EngineState, diff --git a/crates/nu-command/src/dataframe/expressions/quantile.rs b/crates/nu-command/src/dataframe/expressions/quantile.rs index d0a5c31668..5dfb48ed8c 100644 --- a/crates/nu-command/src/dataframe/expressions/quantile.rs +++ b/crates/nu-command/src/dataframe/expressions/quantile.rs @@ -55,6 +55,10 @@ impl Command for ExprQuantile { }] } + fn search_terms(&self) -> Vec<&str> { + vec!["statistics", "percentile", "distribution"] + } + fn run( &self, engine_state: &EngineState, diff --git a/crates/nu-command/src/dataframe/expressions/when.rs b/crates/nu-command/src/dataframe/expressions/when.rs index d92a2bcbf7..694975ba2c 100644 --- a/crates/nu-command/src/dataframe/expressions/when.rs +++ b/crates/nu-command/src/dataframe/expressions/when.rs @@ -85,6 +85,10 @@ impl Command for ExprWhen { ] } + fn search_terms(&self) -> Vec<&str> { + vec!["condition", "match", "if", "else"] + } + fn run( &self, engine_state: &EngineState, diff --git a/crates/nu-command/src/random/bool.rs b/crates/nu-command/src/random/bool.rs index 8b41179f94..b53e79d799 100644 --- a/crates/nu-command/src/random/bool.rs +++ b/crates/nu-command/src/random/bool.rs @@ -31,6 +31,10 @@ impl Command for SubCommand { "Generate a random boolean value" } + fn search_terms(&self) -> Vec<&str> { + vec!["generate", "boolean", "true", "false", "1", "0"] + } + fn run( &self, engine_state: &EngineState, diff --git a/crates/nu-command/src/random/chars.rs b/crates/nu-command/src/random/chars.rs index 5fbc5ce7ad..df0a340781 100644 --- a/crates/nu-command/src/random/chars.rs +++ b/crates/nu-command/src/random/chars.rs @@ -31,6 +31,10 @@ impl Command for SubCommand { "Generate random chars" } + fn search_terms(&self) -> Vec<&str> { + vec!["generate", "character", "symbol", "alphanumeric"] + } + fn run( &self, engine_state: &EngineState, diff --git a/crates/nu-command/src/random/decimal.rs b/crates/nu-command/src/random/decimal.rs index 36642a9cd0..78dd6d7c94 100644 --- a/crates/nu-command/src/random/decimal.rs +++ b/crates/nu-command/src/random/decimal.rs @@ -27,6 +27,10 @@ impl Command for SubCommand { "Generate a random decimal within a range [min..max]" } + fn search_terms(&self) -> Vec<&str> { + vec!["generate", "float"] + } + fn run( &self, engine_state: &EngineState, diff --git a/crates/nu-command/src/random/dice.rs b/crates/nu-command/src/random/dice.rs index 62fc1b6327..b3bbdddd5d 100644 --- a/crates/nu-command/src/random/dice.rs +++ b/crates/nu-command/src/random/dice.rs @@ -37,6 +37,10 @@ impl Command for SubCommand { "Generate a random dice roll" } + fn search_terms(&self) -> Vec<&str> { + vec!["generate", "die", "1-6"] + } + fn run( &self, engine_state: &EngineState, diff --git a/crates/nu-command/src/random/integer.rs b/crates/nu-command/src/random/integer.rs index eda0de9a02..afdb4fb9ae 100644 --- a/crates/nu-command/src/random/integer.rs +++ b/crates/nu-command/src/random/integer.rs @@ -27,6 +27,10 @@ impl Command for SubCommand { "Generate a random integer [min..max]" } + fn search_terms(&self) -> Vec<&str> { + vec!["generate", "natural", "number"] + } + fn run( &self, engine_state: &EngineState, diff --git a/crates/nu-command/src/random/uuid.rs b/crates/nu-command/src/random/uuid.rs index 09a30bfe78..b0b6d39e51 100644 --- a/crates/nu-command/src/random/uuid.rs +++ b/crates/nu-command/src/random/uuid.rs @@ -22,6 +22,10 @@ impl Command for SubCommand { "Generate a random uuid4 string" } + fn search_terms(&self) -> Vec<&str> { + vec!["generate", "uuid4"] + } + fn run( &self, _engine_state: &EngineState,