diff --git a/crates/nu-parser/src/lite_parser.rs b/crates/nu-parser/src/lite_parser.rs index 881aaa19d8..6313b01d17 100644 --- a/crates/nu-parser/src/lite_parser.rs +++ b/crates/nu-parser/src/lite_parser.rs @@ -185,6 +185,20 @@ impl LiteBlock { } } +fn last_non_comment_token(tokens: &[Token], cur_idx: usize) -> Option { + let mut expect = TokenContents::Comment; + for token in tokens.iter().take(cur_idx).rev() { + // skip ([Comment]+ [Eol]) pair + match (token.contents, expect) { + (TokenContents::Comment, TokenContents::Comment) + | (TokenContents::Comment, TokenContents::Eol) => expect = TokenContents::Eol, + (TokenContents::Eol, TokenContents::Eol) => expect = TokenContents::Comment, + (token, _) => return Some(token), + } + } + None +} + pub fn lite_parse(tokens: &[Token]) -> (LiteBlock, Option) { let mut block = LiteBlock::new(); let mut curr_pipeline = LitePipeline::new(); @@ -203,7 +217,7 @@ pub fn lite_parse(tokens: &[Token]) -> (LiteBlock, Option) { let mut error = None; - for token in tokens.iter() { + for (idx, token) in tokens.iter().enumerate() { match &token.contents { TokenContents::PipePipe => { error = error.or(Some(ParseError::ShellOrOr(token.span))); @@ -294,7 +308,13 @@ pub fn lite_parse(tokens: &[Token]) -> (LiteBlock, Option) { last_connector_span = Some(token.span); } TokenContents::Eol => { - if last_token != TokenContents::Pipe && last_token != TokenContents::OutGreaterThan + // Handle `[Command] [Pipe] ([Comment] | [Eol])+ [Command]` + // + // `[Eol]` branch checks if previous token is `[Pipe]` to construct pipeline + // and so `[Comment] | [Eol]` should be ignore to make it work + let actual_token = last_non_comment_token(tokens, idx); + if actual_token != Some(TokenContents::Pipe) + && actual_token != Some(TokenContents::OutGreaterThan) { if !curr_command.is_empty() { match last_connector { @@ -451,7 +471,7 @@ pub fn lite_parse(tokens: &[Token]) -> (LiteBlock, Option) { block.push(curr_pipeline); } - if last_token == TokenContents::Pipe { + if last_non_comment_token(tokens, tokens.len()) == Some(TokenContents::Pipe) { ( block, Some(ParseError::UnexpectedEof( diff --git a/src/tests/test_parser.rs b/src/tests/test_parser.rs index 57e24aed53..49289a7cf2 100644 --- a/src/tests/test_parser.rs +++ b/src/tests/test_parser.rs @@ -135,6 +135,41 @@ fn comment_skipping_2() -> TestResult { ) } +#[test] +fn comment_skipping_in_pipeline_1() -> TestResult { + run_test( + r#"[1,2,3] | #comment + each { |$it| $it + 2 } | # foo + math sum #bar"#, + "12", + ) +} + +#[test] +fn comment_skipping_in_pipeline_2() -> TestResult { + run_test( + r#"[1,2,3] #comment + | #comment2 + each { |$it| $it + 2 } #foo + | # bar + math sum #baz"#, + "12", + ) +} + +#[test] +fn comment_skipping_in_pipeline_3() -> TestResult { + run_test( + r#"[1,2,3] | #comment + #comment2 + each { |$it| $it + 2 } #foo + | # bar + #baz + math sum #foobar"#, + "12", + ) +} + #[test] fn bad_var_name() -> TestResult { fail_test(r#"let $"foo bar" = 4"#, "can't contain")