Public/nushell
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clean-up and adding comments

Browse Source
This commit is contained in:
Antonio Natilla 2021-11-03 20:05:24 +01:00
parent 806cd4851f
commit bfae75ca2e
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
crates/nu-command/src/strings/format/command.rs
View File

@ -36,7 +36,6 @@ impl Command for Format {
match specified_pattern { match specified_pattern {
Err(e) => Err(e), Err(e) => Err(e),
Ok(pattern) => { Ok(pattern) => {
// Handle the pattern
let string_pattern = pattern.as_string().unwrap(); let string_pattern = pattern.as_string().unwrap();
let ops = extract_formatting_operations(string_pattern); let ops = extract_formatting_operations(string_pattern);
format(input, &ops) format(input, &ops)
@ -69,6 +68,12 @@ enum FormatOperation {
ValueFromColumn(String), ValueFromColumn(String),
} }
/// Given a pattern that is fed into the Format command, we can process it and subdivide it
/// in two kind of operations.
/// FormatOperation::FixedText contains a portion of the patter that has to be placed
/// there without any further processing.
/// FormatOperation::ValueFromColumn contains the name of a column whose values will be
/// formatted according to the input pattern.
fn extract_formatting_operations(input: String) -> Vec<FormatOperation> { fn extract_formatting_operations(input: String) -> Vec<FormatOperation> {
let mut output = vec![]; let mut output = vec![];
@ -107,12 +112,14 @@ fn extract_formatting_operations(input: String) -> Vec<FormatOperation> {
output output
} }
/// Format the incoming PipelineData according to the pattern
fn format( fn format(
input_data: PipelineData, input_data: PipelineData,
format_operations: &[FormatOperation], format_operations: &[FormatOperation],
) -> Result<PipelineData, ShellError> { ) -> Result<PipelineData, ShellError> {
let data_as_value = input_data.into_value(); let data_as_value = input_data.into_value();
eprintln!("{:#?}", data_as_value);
// We can only handle a Record or a List of Record's
match data_as_value { match data_as_value {
Value::Record { .. } => match format_record(format_operations, &data_as_value) { Value::Record { .. } => match format_record(format_operations, &data_as_value) {
Ok(value) => Ok(PipelineData::Value(Value::string(value, Span::unknown()))), Ok(value) => Ok(PipelineData::Value(Value::string(value, Span::unknown()))),