From c78e28511d5e7b95167aa3475e90fcfcd9ff5895 Mon Sep 17 00:00:00 2001 From: Reilly Wood <26268125+rgwood@users.noreply.github.com> Date: Thu, 28 Apr 2022 12:39:21 -0700 Subject: [PATCH] CI: make Clippy reuse build artifacts, other cleanup (#5357) * CI: move clippy after build so it can reuse build artifacts * CI: Remove unused rustfmt+clippy from venv --- .github/workflows/ci.yml | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 309618f7b3..cdf0f33f05 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -45,23 +45,23 @@ jobs: command: fmt args: --all -- --check - - name: Clippy - uses: actions-rs/cargo@v1 - with: - command: clippy - args: --all ${{ matrix.flags }} -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect - - name: Build Nushell uses: actions-rs/cargo@v1 with: command: build - args: ${{ matrix.flags }} + args: --workspace ${{ matrix.flags }} + + - name: Clippy + uses: actions-rs/cargo@v1 + with: + command: clippy + args: --workspace ${{ matrix.flags }} -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect - name: Tests uses: actions-rs/cargo@v1 with: command: test - args: --all ${{ matrix.flags }} + args: --workspace ${{ matrix.flags }} python-virtualenv: @@ -85,7 +85,6 @@ jobs: profile: minimal toolchain: ${{ matrix.rust }} override: true - components: rustfmt, clippy - uses: Swatinem/rust-cache@v1 with: