Public/nushell
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Simplify column look-up in default

Browse Source 
Since we make the promise that record keys/columns are exclusice we
don't have to go through all columns after we have found the first one.
Should permit some short-circuiting if the column is found early.
This commit is contained in:
sholderbach 2024-08-02 23:10:19 +02:00
parent af34d5c062
commit e62356f5ec
1 changed files with 4 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
crates/nu-command/src/filters/default.rs
View File

@ -102,18 +102,11 @@ fn default(
val: ref mut record, val: ref mut record,
.. ..
} => { } => {
let mut found = false; if let Some(val) = record.to_mut().get_mut(&column.item) {
if matches!(val, Value::Nothing { .. }) {
for (col, val) in record.to_mut().iter_mut() { *val = value.clone();
if *col == column.item {
found = true;
if matches!(val, Value::Nothing { .. }) {
*val = value.clone();
}
} }
} } else {
if !found {
record.to_mut().push(column.item.clone(), value.clone()); record.to_mut().push(column.item.clone(), value.clone());
} }