From ea0205f2ffcadc977ac58af164ef8c12f91daf1b Mon Sep 17 00:00:00 2001 From: Darren Schroeder <343840+fdncred@users.noreply.github.com> Date: Wed, 14 Apr 2021 07:55:58 -0500 Subject: [PATCH] remote --help/-h from $scope.commands display (#3311) * remote --help/-h from $scope.commands * change a test --- crates/nu-engine/src/evaluate/scope.rs | 5 ++++- crates/nu-engine/tests/evaluate/variables.rs | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/crates/nu-engine/src/evaluate/scope.rs b/crates/nu-engine/src/evaluate/scope.rs index 1836c5415d..7355185a26 100644 --- a/crates/nu-engine/src/evaluate/scope.rs +++ b/crates/nu-engine/src/evaluate/scope.rs @@ -52,7 +52,10 @@ impl Scope { for frame in self.frames.lock().iter().rev() { for (name, command) in frame.commands.iter() { if !output.contains_key(name) { - output.insert(name.clone(), command.signature()); + let mut sig = command.signature(); + // don't show --help and -h in the command arguments for $scope.commands + sig.remove_named("help"); + output.insert(name.clone(), sig); } } } diff --git a/crates/nu-engine/tests/evaluate/variables.rs b/crates/nu-engine/tests/evaluate/variables.rs index f00db130da..e62a8f146e 100644 --- a/crates/nu-engine/tests/evaluate/variables.rs +++ b/crates/nu-engine/tests/evaluate/variables.rs @@ -82,7 +82,7 @@ fn scope_variable_with_command_present() { assert_that!( nu.pipeline("def meaning-of-life [--number: int] { echo $number }; echo $scope.commands | get meaning-of-life"), - says().to_stdout("-h --help --number") + says().to_stdout("--number") ); }) }