From f18252429838c78e08f37f6f1c464241604c7a00 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20=C5=BD=C3=A1dn=C3=ADk?= Date: Sun, 31 Oct 2021 17:46:37 +0200 Subject: [PATCH] Add TODO notes --- crates/nu-parser/src/parse_keywords.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/crates/nu-parser/src/parse_keywords.rs b/crates/nu-parser/src/parse_keywords.rs index 7606a1a486..c36a00d724 100644 --- a/crates/nu-parser/src/parse_keywords.rs +++ b/crates/nu-parser/src/parse_keywords.rs @@ -511,6 +511,7 @@ pub fn parse_use( ) } else { // TODO: Handle invalid UTF-8 conversion + // TODO: Do not close over when loading module from file // It could be a file let module_filename = String::from_utf8_lossy(&import_pattern.head).to_string(); let module_path = Path::new(&module_filename); @@ -734,6 +735,8 @@ pub fn parse_hide( }; for name in names_to_hide { + // TODO: `use spam; use spam foo; hide foo` will hide both `foo` and `spam foo` since + // they point to the same DeclId. Do we want to keep it that way? if working_set.hide_decl(&name).is_none() { error = error.or_else(|| Some(ParseError::UnknownCommand(spans[1]))); }