# Description As part of the refactor to split spans off of Value, this moves to using helper functions to create values, and using `.span()` instead of matching span out of Value directly. Hoping to get a few more helping hands to finish this, as there are a lot of commands to update :) # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. --> --------- Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com> Co-authored-by: WindSoilder <windsoilder@outlook.com>
81 lines
2.2 KiB
Rust
81 lines
2.2 KiB
Rust
use nu_engine::eval_expression;
|
|
use nu_protocol::ast::Call;
|
|
use nu_protocol::engine::{Command, EngineState, Stack};
|
|
use nu_protocol::{
|
|
Category, Example, IntoPipelineData, PipelineData, ShellError, Signature, Span, SyntaxShape,
|
|
Type, Value,
|
|
};
|
|
|
|
#[derive(Clone)]
|
|
pub struct BytesBuild;
|
|
|
|
impl Command for BytesBuild {
|
|
fn name(&self) -> &str {
|
|
"bytes build"
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Create bytes from the arguments."
|
|
}
|
|
|
|
fn search_terms(&self) -> Vec<&str> {
|
|
vec!["concatenate", "join"]
|
|
}
|
|
|
|
fn signature(&self) -> nu_protocol::Signature {
|
|
Signature::build("bytes build")
|
|
.input_output_types(vec![(Type::Nothing, Type::Binary)])
|
|
.rest("rest", SyntaxShape::Any, "list of bytes")
|
|
.category(Category::Bytes)
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![Example {
|
|
example: "bytes build 0x[01 02] 0x[03] 0x[04]",
|
|
description: "Builds binary data from 0x[01 02], 0x[03], 0x[04]",
|
|
result: Some(Value::binary(
|
|
vec![0x01, 0x02, 0x03, 0x04],
|
|
Span::test_data(),
|
|
)),
|
|
}]
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
_input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let mut output = vec![];
|
|
for expr in call.positional_iter() {
|
|
let val = eval_expression(engine_state, stack, expr)?;
|
|
match val {
|
|
Value::Binary { mut val, .. } => output.append(&mut val),
|
|
// Explicitly propagate errors instead of dropping them.
|
|
Value::Error { error, .. } => return Err(*error),
|
|
other => {
|
|
return Err(ShellError::TypeMismatch {
|
|
err_message: "only binary data arguments are supported".to_string(),
|
|
span: other.span(),
|
|
})
|
|
}
|
|
}
|
|
}
|
|
|
|
Ok(Value::binary(output, call.head).into_pipeline_data())
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod test {
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn test_examples() {
|
|
use crate::test_examples;
|
|
|
|
test_examples(BytesBuild {})
|
|
}
|
|
}
|