# Description Continuing from #12568, this PR further reduces the size of `Expr` from 64 to 40 bytes. It also reduces `Expression` from 128 to 96 bytes and `Type` from 32 to 24 bytes. This was accomplished by: - for `Expr` with multiple fields (e.g., `Expr::Thing(A, B, C)`), merging the fields into new AST struct types and then boxing this struct (e.g. `Expr::Thing(Box<ABC>)`). - replacing `Vec<T>` with `Box<[T]>` in multiple places. `Expr`s and `Expression`s should rarely be mutated, if at all, so this optimization makes sense. By reducing the size of these types, I didn't notice a large performance improvement (at least compared to #12568). But this PR does reduce the memory usage of nushell. My config is somewhat light so I only noticed a difference of 1.4MiB (38.9MiB vs 37.5MiB). --------- Co-authored-by: Stefan Holderbach <sholderbach@users.noreply.github.com>
114 lines
3.3 KiB
Rust
114 lines
3.3 KiB
Rust
use nu_engine::command_prelude::*;
|
|
use reedline::{
|
|
get_reedline_edit_commands, get_reedline_keybinding_modifiers, get_reedline_keycodes,
|
|
get_reedline_prompt_edit_modes, get_reedline_reedline_events,
|
|
};
|
|
|
|
#[derive(Clone)]
|
|
pub struct KeybindingsList;
|
|
|
|
impl Command for KeybindingsList {
|
|
fn name(&self) -> &str {
|
|
"keybindings list"
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build(self.name())
|
|
.input_output_types(vec![(Type::Nothing, Type::table())])
|
|
.switch("modifiers", "list of modifiers", Some('m'))
|
|
.switch("keycodes", "list of keycodes", Some('k'))
|
|
.switch("modes", "list of edit modes", Some('o'))
|
|
.switch("events", "list of reedline event", Some('e'))
|
|
.switch("edits", "list of edit commands", Some('d'))
|
|
.category(Category::Platform)
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"List available options that can be used to create keybindings."
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![
|
|
Example {
|
|
description: "Get list of key modifiers",
|
|
example: "keybindings list --modifiers",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "Get list of reedline events and edit commands",
|
|
example: "keybindings list -e -d",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "Get list with all the available options",
|
|
example: "keybindings list",
|
|
result: None,
|
|
},
|
|
]
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
_engine_state: &EngineState,
|
|
_stack: &mut Stack,
|
|
call: &Call,
|
|
_input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let records = if call.named_len() == 0 {
|
|
let all_options = ["modifiers", "keycodes", "edits", "modes", "events"];
|
|
all_options
|
|
.iter()
|
|
.flat_map(|argument| get_records(argument, call.head))
|
|
.collect()
|
|
} else {
|
|
call.named_iter()
|
|
.flat_map(|(argument, _, _)| get_records(argument.item.as_str(), call.head))
|
|
.collect()
|
|
};
|
|
|
|
Ok(Value::list(records, call.head).into_pipeline_data())
|
|
}
|
|
}
|
|
|
|
fn get_records(entry_type: &str, span: Span) -> Vec<Value> {
|
|
let values = match entry_type {
|
|
"modifiers" => get_reedline_keybinding_modifiers().sorted(),
|
|
"keycodes" => get_reedline_keycodes().sorted(),
|
|
"edits" => get_reedline_edit_commands().sorted(),
|
|
"modes" => get_reedline_prompt_edit_modes().sorted(),
|
|
"events" => get_reedline_reedline_events().sorted(),
|
|
_ => Vec::new(),
|
|
};
|
|
|
|
values
|
|
.iter()
|
|
.map(|edit| edit.split('\n'))
|
|
.flat_map(|edit| edit.map(|edit| convert_to_record(edit, entry_type, span)))
|
|
.collect()
|
|
}
|
|
|
|
fn convert_to_record(edit: &str, entry_type: &str, span: Span) -> Value {
|
|
Value::record(
|
|
record! {
|
|
"type" => Value::string(entry_type, span),
|
|
"name" => Value::string(edit, span),
|
|
},
|
|
span,
|
|
)
|
|
}
|
|
|
|
// Helper to sort a vec and return a vec
|
|
trait SortedImpl {
|
|
fn sorted(self) -> Self;
|
|
}
|
|
|
|
impl<E> SortedImpl for Vec<E>
|
|
where
|
|
E: std::cmp::Ord,
|
|
{
|
|
fn sorted(mut self) -> Self {
|
|
self.sort();
|
|
self
|
|
}
|
|
}
|