nushell/crates/nu-cli/src/completions
Leon 220b105efb
Reduced LOC by replacing several instances of Value::Int {}, Value::Float{}, Value::Bool {}, and Value::String {} with Value::int(), Value::float(), Value::boolean() and Value::string() (#7412)
# Description

While perusing Value.rs, I noticed the `Value::int()`, `Value::float()`,
`Value::boolean()` and `Value::string()` constructors, which seem
designed to make it easier to construct various Values, but which aren't
used often at all in the codebase. So, using a few find-replaces
regexes, I increased their usage. This reduces overall LOC because
structures like this:
```
Value::Int {
  val: a,
  span: head
}
```
are changed into
```
Value::int(a, head)
```
and are respected as such by the project's formatter.
There are little readability concerns because the second argument to all
of these is `span`, and it's almost always extremely obvious which is
the span at every callsite.

# User-Facing Changes

None.

# Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass

# After Submitting

If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
2022-12-09 11:37:51 -05:00
..
base.rs Add MatchAlgorithm for completion suggestions (#5244) 2022-04-23 10:01:19 -05:00
command_completions.rs fix external completions; add a caret when there is overlap (#7405) 2022-12-09 22:27:50 +13:00
completer.rs Reduced LOC by replacing several instances of Value::Int {}, Value::Float{}, Value::Bool {}, and Value::String {} with Value::int(), Value::float(), Value::boolean() and Value::string() (#7412) 2022-12-09 11:37:51 -05:00
completion_options.rs Update path completions to handle spaces (#5419) 2022-05-03 12:37:38 +12:00
custom_completions.rs Improve empty pipelines (#7383) 2022-12-08 07:31:57 +13:00
directory_completions.rs Add quotes to hash file autocomplete (#7398) 2022-12-08 21:37:10 +01:00
dotnu_completions.rs nu-cli/completions: verify case for matching dir, .nu, file and command (#5506) 2022-05-11 16:16:52 -05:00
file_completions.rs Add quotes to hash file autocomplete (#7398) 2022-12-08 21:37:10 +01:00
flag_completions.rs Don't resuggest accepted completions (#5369) 2022-05-02 11:35:37 +02:00
mod.rs Update path completions to handle spaces (#5419) 2022-05-03 12:37:38 +12:00
variable_completions.rs Protocol: debug_assert!() Span to reflect a valid slice (#6806) 2022-12-03 11:44:12 +02:00