# Description The `ShellError` enum at the moment is kind of messy. Many variants are basic tuple structs where you always have to reference the implementation with its macro invocation to know which field serves which purpose. Furthermore we have both variants that are kind of redundant or either overly broad to be useful for the user to match on or overly specific with few uses. So I set out to start fixing the lacking documentation and naming to make it feasible to critically review the individual usages and fix those. Furthermore we can decide to join or split up variants that don't seem to be fit for purpose. Feel free to add review comments if you spot inconsistent use of `ShellError` variants. - Name fields on `ShellError::OperatorOverflow` - Name fields on `ShellError::PipelineMismatch` - Add doc to `ShellError::OnlySupportsThisInputType` - Name `ShellError::OnlySupportsThisInputType` - Name field on `ShellError::PipelineEmpty` - Comment about issues with `TypeMismatch*` - Fix a few `exp_input_type`s - Name fields on `ShellError::InvalidRange` # User-Facing Changes (None now, end goal more explicit and consistent error messages) # Tests + Formatting (No additional tests needed so far)
138 lines
4.1 KiB
Rust
138 lines
4.1 KiB
Rust
use crate::input_handler::{operate, CmdArgument};
|
|
use nu_engine::CallExt;
|
|
use nu_protocol::ast::Call;
|
|
use nu_protocol::ast::CellPath;
|
|
use nu_protocol::engine::{Command, EngineState, Stack};
|
|
use nu_protocol::Category;
|
|
use nu_protocol::Spanned;
|
|
use nu_protocol::{Example, PipelineData, ShellError, Signature, Span, SyntaxShape, Type, Value};
|
|
|
|
struct Arguments {
|
|
substring: String,
|
|
cell_paths: Option<Vec<CellPath>>,
|
|
case_insensitive: bool,
|
|
}
|
|
|
|
impl CmdArgument for Arguments {
|
|
fn take_cell_paths(&mut self) -> Option<Vec<CellPath>> {
|
|
self.cell_paths.take()
|
|
}
|
|
}
|
|
|
|
#[derive(Clone)]
|
|
|
|
pub struct SubCommand;
|
|
|
|
impl Command for SubCommand {
|
|
fn name(&self) -> &str {
|
|
"str starts-with"
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build("str starts-with")
|
|
.input_output_types(vec![(Type::String, Type::Bool)])
|
|
.vectorizes_over_list(true)
|
|
.required("string", SyntaxShape::String, "the string to match")
|
|
.rest(
|
|
"rest",
|
|
SyntaxShape::CellPath,
|
|
"For a data structure input, check strings at the given cell paths, and replace with result",
|
|
)
|
|
.switch("ignore-case", "search is case insensitive", Some('i'))
|
|
.category(Category::Strings)
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Check if an input starts with a string."
|
|
}
|
|
|
|
fn search_terms(&self) -> Vec<&str> {
|
|
vec!["prefix", "match", "find", "search"]
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let substring: Spanned<String> = call.req(engine_state, stack, 0)?;
|
|
let cell_paths: Vec<CellPath> = call.rest(engine_state, stack, 1)?;
|
|
let cell_paths = (!cell_paths.is_empty()).then_some(cell_paths);
|
|
let args = Arguments {
|
|
substring: substring.item,
|
|
cell_paths,
|
|
case_insensitive: call.has_flag("ignore-case"),
|
|
};
|
|
operate(action, args, input, call.head, engine_state.ctrlc.clone())
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![
|
|
Example {
|
|
description: "Checks if input string starts with 'my'",
|
|
example: "'my_library.rb' | str starts-with 'my'",
|
|
result: Some(Value::test_bool(true)),
|
|
},
|
|
Example {
|
|
description: "Checks if input string starts with 'Car'",
|
|
example: "'Cargo.toml' | str starts-with 'Car'",
|
|
result: Some(Value::test_bool(true)),
|
|
},
|
|
Example {
|
|
description: "Checks if input string starts with '.toml'",
|
|
example: "'Cargo.toml' | str starts-with '.toml'",
|
|
result: Some(Value::test_bool(false)),
|
|
},
|
|
Example {
|
|
description: "Checks if input string starts with 'cargo', case-insensitive",
|
|
example: "'Cargo.toml' | str starts-with -i 'cargo'",
|
|
result: Some(Value::test_bool(true)),
|
|
},
|
|
]
|
|
}
|
|
}
|
|
|
|
fn action(
|
|
input: &Value,
|
|
Arguments {
|
|
substring,
|
|
case_insensitive,
|
|
..
|
|
}: &Arguments,
|
|
head: Span,
|
|
) -> Value {
|
|
match input {
|
|
Value::String { val: s, .. } => {
|
|
let starts_with = if *case_insensitive {
|
|
s.to_lowercase().starts_with(&substring.to_lowercase())
|
|
} else {
|
|
s.starts_with(substring)
|
|
};
|
|
Value::boolean(starts_with, head)
|
|
}
|
|
Value::Error { .. } => input.clone(),
|
|
_ => Value::Error {
|
|
error: ShellError::OnlySupportsThisInputType {
|
|
exp_input_type: "string".into(),
|
|
wrong_type: input.get_type().to_string(),
|
|
dst_span: head,
|
|
src_span: input.expect_span(),
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn test_examples() {
|
|
use crate::test_examples;
|
|
|
|
test_examples(SubCommand {})
|
|
}
|
|
}
|