related to - https://github.com/nushell/nushell/pull/9973 - https://github.com/nushell/nushell/pull/9918 thanks to @jntrnr and their super useful tips on this PR, i learned about the parser + evaluation, so 🙏 # Description because we already have `null` as the value of the type `nothing` and as a followup to the two other attempts of mine, i propose to remove the redundant `$nothing` built-in variable 😋 this PR is the first step, deprecating `$nothing`. a followup PR will remove it altogether and wait for 0.87 👍 ⚙️ **details**: a new `NOTHING_VARIABLE_ID = 3` has been added, parsing `$nothing` will create it, finally a `Value::Nothing` will be produced and a warning will be reported. this PR already fixes the `toolkit.nu` module so that it does not throw a bunch of warnings each time 👌 # User-Facing Changes `$nothing` is now deprecated and will be removed in 0.87 ```nushell > $nothing Error: × Deprecated variable ╭─[entry #1:1:1] 1 │ $nothing · ────┬─── · ╰── `$nothing` is deprecated and will be removed in 0.87. ╰──── help: Use `null` instead ``` # Tests + Formatting tests have been updated, especially - `nothing_fails_string` - `nothing_fails_int` which use a variable called `nil` now to make sure `nothing` does not support cell paths 👍 # After Submitting classic deprecation mention 👍
157 lines
4.0 KiB
Rust
157 lines
4.0 KiB
Rust
use crate::tests::{fail_test, run_test, TestResult};
|
|
|
|
// Tests for null / null / Value::Nothing
|
|
#[test]
|
|
fn nothing_fails_string() -> TestResult {
|
|
fail_test("let nil = null; $nil.foo", "doesn't support cell paths")
|
|
}
|
|
|
|
#[test]
|
|
fn nothing_fails_int() -> TestResult {
|
|
fail_test("let nil = null; $nil.3", "doesn't support cell paths")
|
|
}
|
|
|
|
// Tests for records
|
|
#[test]
|
|
fn record_single_field_success() -> TestResult {
|
|
run_test("{foo: 'bar'}.foo == 'bar'", "true")
|
|
}
|
|
|
|
#[test]
|
|
fn record_single_field_optional_success() -> TestResult {
|
|
run_test("{foo: 'bar'}.foo? == 'bar'", "true")
|
|
}
|
|
|
|
#[test]
|
|
fn get_works_with_cell_path_success() -> TestResult {
|
|
run_test("{foo: 'bar'} | get foo?", "bar")
|
|
}
|
|
|
|
#[test]
|
|
fn get_works_with_cell_path_missing_data() -> TestResult {
|
|
run_test("{foo: 'bar'} | get foobar? | to nuon", "null")
|
|
}
|
|
|
|
#[test]
|
|
fn record_single_field_failure() -> TestResult {
|
|
fail_test("{foo: 'bar'}.foobar", "")
|
|
}
|
|
|
|
#[test]
|
|
fn record_int_failure() -> TestResult {
|
|
fail_test("{foo: 'bar'}.3", "")
|
|
}
|
|
|
|
#[test]
|
|
fn record_single_field_optional() -> TestResult {
|
|
run_test("{foo: 'bar'}.foobar? | to nuon", "null")
|
|
}
|
|
|
|
#[test]
|
|
fn record_single_field_optional_short_circuits() -> TestResult {
|
|
// Check that we return null as soon as the `.foobar?` access
|
|
// fails instead of erroring on the `.baz` access
|
|
run_test("{foo: 'bar'}.foobar?.baz | to nuon", "null")
|
|
}
|
|
|
|
#[test]
|
|
fn record_multiple_optional_fields() -> TestResult {
|
|
run_test("{foo: 'bar'}.foobar?.baz? | to nuon", "null")
|
|
}
|
|
|
|
#[test]
|
|
fn nested_record_field_success() -> TestResult {
|
|
run_test("{foo: {bar: 'baz'} }.foo.bar == 'baz'", "true")
|
|
}
|
|
|
|
#[test]
|
|
fn nested_record_field_failure() -> TestResult {
|
|
fail_test("{foo: {bar: 'baz'} }.foo.asdf", "")
|
|
}
|
|
|
|
#[test]
|
|
fn nested_record_field_optional() -> TestResult {
|
|
run_test("{foo: {bar: 'baz'} }.foo.asdf? | to nuon", "null")
|
|
}
|
|
|
|
#[test]
|
|
fn record_with_nested_list_success() -> TestResult {
|
|
run_test("{foo: [{bar: 'baz'}]}.foo.0.bar == 'baz'", "true")
|
|
}
|
|
|
|
#[test]
|
|
fn record_with_nested_list_int_failure() -> TestResult {
|
|
fail_test("{foo: [{bar: 'baz'}]}.foo.3.bar", "")
|
|
}
|
|
|
|
#[test]
|
|
fn record_with_nested_list_column_failure() -> TestResult {
|
|
fail_test("{foo: [{bar: 'baz'}]}.foo.0.asdf", "")
|
|
}
|
|
|
|
// Tests for lists
|
|
#[test]
|
|
fn list_single_field_success() -> TestResult {
|
|
run_test("[{foo: 'bar'}].foo.0 == 'bar'", "true")?;
|
|
// test field access both ways
|
|
run_test("[{foo: 'bar'}].0.foo == 'bar'", "true")
|
|
}
|
|
|
|
#[test]
|
|
fn list_single_field_failure() -> TestResult {
|
|
fail_test("[{foo: 'bar'}].asdf", "")
|
|
}
|
|
|
|
// Test the scenario where the requested column is not present in all rows
|
|
#[test]
|
|
fn jagged_list_access_fails() -> TestResult {
|
|
fail_test("[{foo: 'bar'}, {}].foo", "cannot find column")?;
|
|
fail_test("[{}, {foo: 'bar'}].foo", "cannot find column")
|
|
}
|
|
|
|
#[test]
|
|
fn jagged_list_optional_access_succeeds() -> TestResult {
|
|
run_test("[{foo: 'bar'}, {}].foo?.0", "bar")?;
|
|
run_test("[{foo: 'bar'}, {}].foo?.1 | to nuon", "null")?;
|
|
|
|
run_test("[{}, {foo: 'bar'}].foo?.0 | to nuon", "null")?;
|
|
run_test("[{}, {foo: 'bar'}].foo?.1", "bar")
|
|
}
|
|
|
|
// test that accessing a nonexistent row fails
|
|
#[test]
|
|
fn list_row_access_failure() -> TestResult {
|
|
fail_test("[{foo: 'bar'}, {foo: 'baz'}].2", "")
|
|
}
|
|
|
|
#[test]
|
|
fn list_row_optional_access_succeeds() -> TestResult {
|
|
run_test("[{foo: 'bar'}, {foo: 'baz'}].2? | to nuon", "null")?;
|
|
run_test("[{foo: 'bar'}, {foo: 'baz'}].3? | to nuon", "null")
|
|
}
|
|
|
|
// regression test for an old bug
|
|
#[test]
|
|
fn do_not_delve_too_deep_in_nested_lists() -> TestResult {
|
|
fail_test("[[{foo: bar}]].foo", "cannot find column")
|
|
}
|
|
|
|
#[test]
|
|
fn cell_path_literals() -> TestResult {
|
|
run_test("let cell_path = $.a.b; {a: {b: 3}} | get $cell_path", "3")
|
|
}
|
|
|
|
// Test whether cell path access short-circuits properly
|
|
#[test]
|
|
fn deeply_nested_cell_path_short_circuits() -> TestResult {
|
|
run_test(
|
|
"{foo: [{bar: 'baz'}]}.foo.3?.bar.asdfdafg.234.foobar | to nuon",
|
|
"null",
|
|
)
|
|
}
|
|
|
|
#[test]
|
|
fn cell_path_type() -> TestResult {
|
|
run_test("$.a.b | describe", "cell-path")
|
|
}
|