5e70d4121a
# Description This PR tries to resolve the overloading issue by going back to our original naming convention for dataframes. So, this PR renames all dataframe commands with a prefix of `dfr`. Some commands like `open-df` were renamed to `dfr open` and things like `into df` were renamed `dfr into-df`. I'm sure we can optimize naming a bit, but it seems to compile now. # User-Facing Changes All dataframe commands are prefixed with dfr. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
93 lines
2.5 KiB
Rust
93 lines
2.5 KiB
Rust
use super::super::super::values::{Column, NuDataFrame};
|
|
|
|
use nu_protocol::{
|
|
ast::Call,
|
|
engine::{Command, EngineState, Stack},
|
|
Category, Example, PipelineData, ShellError, Signature, Span, Type, Value,
|
|
};
|
|
use polars::prelude::{DatetimeMethods, IntoSeries};
|
|
|
|
#[derive(Clone)]
|
|
pub struct GetHour;
|
|
|
|
impl Command for GetHour {
|
|
fn name(&self) -> &str {
|
|
"dfr get-hour"
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Gets hour from date"
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build(self.name())
|
|
.input_type(Type::Custom("dataframe".into()))
|
|
.output_type(Type::Custom("dataframe".into()))
|
|
.category(Category::Custom("dataframe".into()))
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![Example {
|
|
description: "Returns hour from a date",
|
|
example: r#"let dt = ('2020-08-04T16:39:18+00:00' | into datetime -z 'UTC');
|
|
let df = ([$dt $dt] | dfr into-df);
|
|
$df | dfr get-hour"#,
|
|
result: Some(
|
|
NuDataFrame::try_from_columns(vec![Column::new(
|
|
"0".to_string(),
|
|
vec![Value::test_int(16), Value::test_int(16)],
|
|
)])
|
|
.expect("simple df for test should not fail")
|
|
.into_value(Span::test_data()),
|
|
),
|
|
}]
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
command(engine_state, stack, call, input)
|
|
}
|
|
}
|
|
|
|
fn command(
|
|
_engine_state: &EngineState,
|
|
_stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let df = NuDataFrame::try_from_pipeline(input, call.head)?;
|
|
let series = df.as_series(call.head)?;
|
|
|
|
let casted = series.datetime().map_err(|e| {
|
|
ShellError::GenericError(
|
|
"Error casting to datetime type".into(),
|
|
e.to_string(),
|
|
Some(call.head),
|
|
None,
|
|
Vec::new(),
|
|
)
|
|
})?;
|
|
|
|
let res = casted.hour().into_series();
|
|
|
|
NuDataFrame::try_from_series(vec![res], call.head)
|
|
.map(|df| PipelineData::Value(NuDataFrame::into_value(df, call.head), None))
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod test {
|
|
use super::super::super::super::super::IntoDatetime;
|
|
use super::super::super::super::test_dataframe::test_dataframe;
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn test_examples() {
|
|
test_dataframe(vec![Box::new(GetHour {}), Box::new(IntoDatetime {})])
|
|
}
|
|
}
|