nushell/crates/nu-command/src
Christian Friedow 66ad83c15c
from ssv --aligned-columns should separate lines by character index instead of byte index (#8558)
# Description

## Symptom
Lines which are input into `from ssv --aligned-columns` are split
incorrectly of they contain utf-8 characters which have the length of
multiple bytes. Notice how the values of the `Bars` column bleeds into
the `Security` column in the following output (the big grey areas are
censored data ;) ):

![before-patch](https://user-images.githubusercontent.com/17351844/226757737-be7ca493-5c64-4a91-9153-984df515bb8c.png)

## Problem
The function behind `from ssv --aligned-columns` splits lines into
fields by byte index (which is default behavior of str.get(...) in Rust)
instead of character index. If the header row has a different length in
bytes than the remaining table rows, the split is executed incorrectly.

## Solution
The function behind `from ssv --aligned-columns1 now separates lines by
character index instead of byte index. This productes the following
(correct) output (the big grey areas are censored data ;) ):

![after-patch](https://user-images.githubusercontent.com/17351844/226757850-7acaebf3-2d40-4f85-b76e-64e465254bda.png)
2023-03-22 17:54:18 -05:00
..
bits Box ShellError in Value::Error (#8375) 2023-03-12 09:57:27 +01:00
bytes fix: bytes length example description typo (#8550) 2023-03-21 11:41:37 -05:00
charting fix: fixed typo and improved Value TypeMismatch exceptions (#8324) 2023-03-22 09:47:40 +01:00
conversions Box ShellError in Value::Error (#8375) 2023-03-12 09:57:27 +01:00
database Fix SQLite table creation sql (#8430) 2023-03-13 10:11:28 -07:00
dataframe docs: Use capital letters for CSV and JSON acronyms (#8459) 2023-03-15 21:52:13 -07:00
date Box ShellError in Value::Error (#8375) 2023-03-12 09:57:27 +01:00
debug Restrict closure expression to be something like {|| ...} (#8290) 2023-03-17 07:36:28 -05:00
deprecated Revert "Allow NU_LIBS_DIR and friends to be const" (#8501) 2023-03-17 09:33:24 -05:00
env Switch let/let-env family to init with math expressions (#8545) 2023-03-23 09:14:10 +13:00
experimental Uniformize usage() and extra_usage() message ending for commands helper. (#8268) 2023-02-28 21:33:02 -08:00
filesystem Add rest and glob support to 'open' (#8506) 2023-03-18 08:51:39 +13:00
filters FEATURE: add --raw. --tabs and --indent to to nuon as in to json (#8366) 2023-03-20 15:47:18 -05:00
formats from ssv --aligned-columns should separate lines by character index instead of byte index (#8558) 2023-03-22 17:54:18 -05:00
generators Document and critically review ShellError variants - Ep. 2 (#8326) 2023-03-06 11:31:07 +01:00
hash Box ShellError in Value::Error (#8375) 2023-03-12 09:57:27 +01:00
math Box ShellError in Value::Error (#8375) 2023-03-12 09:57:27 +01:00
misc Uniformize usage() and extra_usage() message ending for commands helper. (#8268) 2023-02-28 21:33:02 -08:00
network Box ShellError in Value::Error (#8375) 2023-03-12 09:57:27 +01:00
path Box ShellError in Value::Error (#8375) 2023-03-12 09:57:27 +01:00
platform Box ShellError in Value::Error (#8375) 2023-03-12 09:57:27 +01:00
random Document and critically review ShellError variants - Ep. 3 (#8340) 2023-03-06 18:33:09 +01:00
shells Document and critically review ShellError variants - Ep. 3 (#8340) 2023-03-06 18:33:09 +01:00
strings Add char --list example to char command docs (#8474) 2023-03-17 10:15:41 +01:00
system feat: add a command_not_found hook (#8314) 2023-03-20 17:05:22 +13:00
viewers Optional members in cell paths: Attempt 2 (#8379) 2023-03-15 20:50:58 -07:00
default_context.rs SQL-style join command for Nushell tables (#8424) 2023-03-16 16:57:20 -07:00
example_test.rs cratification: Example support (#8231) 2023-02-27 13:58:56 -08:00
hook.rs feat: add a command_not_found hook (#8314) 2023-03-20 17:05:22 +13:00
input_handler.rs Box ShellError in Value::Error (#8375) 2023-03-12 09:57:27 +01:00
lib.rs feat: add a command_not_found hook (#8314) 2023-03-20 17:05:22 +13:00
progress_bar.rs cp progress bar implementation (#8012) 2023-02-22 11:57:38 -08:00
sort_utils.rs Document and critically review ShellError variants - Ep. 3 (#8340) 2023-03-06 18:33:09 +01:00
util.rs feat: add a command_not_found hook (#8314) 2023-03-20 17:05:22 +13:00