nushell/crates/nu-command/src
Christopher Durham a01ef85bda
Remove registry clean_string hack (#10804)
# Description

Remove the `clean_string` hack used in `registry query`.

This was a workaround for a [bug][gentoo90/winreg-rs#52] in winreg which
has since [been fixed][edf9eef] and released in [winreg v0.12.0].

winreg now properly displays strings in RegKey's Display impl instead of
outputting their debug representation. We remove our `clean_string` such
that registry entries which happen to start/end with `"` or contain `\\`
won't get mangled. This is very important for entries in UNC path format
as those begin with a double backslash.

[gentoo90/winreg-rs#52]:
<https://github.com/gentoo90/winreg-rs/issues/52>
[edf9eef]:
<edf9eef38f>
[winreg v0.12.0]:
<https://github.com/gentoo90/winreg-rs/releases/tag/v0.12.0>

# User-Facing Changes

- `registry query` used to accidentally mangle values that contain a
literal `\\`, such as UNC paths. It no longer does so.

# Tests + Formatting

- [X] `toolkit check pr`
  - 🟢 `toolkit fmt`
  - 🟢 `toolkit clippy`
  - 🟢 `toolkit test`
  - 🟢 `toolkit test stdlib`
2023-10-21 18:50:34 -05:00
..
bytes Add long options for bits and bytes (#10601) 2023-10-05 18:45:28 +02:00
charting Move Value to helpers, separate span call (#10121) 2023-09-03 07:27:29 -07:00
conversions remove into decimal (#10341) 2023-10-10 20:05:44 +02:00
database Move Value to helpers, separate span call (#10121) 2023-09-03 07:27:29 -07:00
date fix clippy (#10659) 2023-10-10 03:31:15 +13:00
debug add a debug info command to show memory info (#10711) 2023-10-14 12:28:48 -05:00
env Fix editor config for reedline and config nu/env (#10535) 2023-09-29 16:36:03 +02:00
experimental Add functions for each Value case (#9736) 2023-07-21 08:20:33 -05:00
filesystem Allow filesystem commands to access files with glob metachars in name (#10694) 2023-10-18 13:31:15 -05:00
filters Allow empty list inputs in group-by and return empty record (#10730) 2023-10-19 12:20:52 +02:00
formats Remove to xml --pretty (#10668) 2023-10-19 18:41:54 +02:00
generators add unfold back with a deprecation warning (#10771) 2023-10-19 19:23:06 +02:00
hash Move Value to helpers, separate span call (#10121) 2023-09-03 07:27:29 -07:00
help Add 'help escapes' command for quick reference of nushell string escapes (#10522) 2023-09-30 09:04:27 -05:00
math Add long options for generators and math (#10752) 2023-10-19 18:17:42 +02:00
misc Add long options for misc and network (#10753) 2023-10-19 18:16:44 +02:00
network Add long options for misc and network (#10753) 2023-10-19 18:16:44 +02:00
path Add long options for path (#10775) 2023-10-19 22:07:01 +02:00
platform Move ansi link from extra to default feature, close #10792 (#10801) 2023-10-21 11:04:37 -05:00
random Add long options for platform and random (#10776) 2023-10-19 22:04:33 +02:00
removed Rename misused "deprecation" to removal (#10000) 2023-08-15 07:17:31 +12:00
shells Fix usage for the exit command. (#9450) 2023-06-16 10:09:02 +02:00
strings Deprecate size to str stats (#10798) 2023-10-21 11:21:34 -05:00
system Remove registry clean_string hack (#10804) 2023-10-21 18:50:34 -05:00
viewers Add long options for viewers (#10787) 2023-10-20 11:43:42 -05:00
default_context.rs Deprecate size to str stats (#10798) 2023-10-21 11:21:34 -05:00
example_test.rs feat: Add unfold command (#10489) 2023-09-30 09:08:06 -05:00
lib.rs Move eval_hook to nu-cmd-base (#10146) 2023-08-29 23:46:50 +02:00
progress_bar.rs cp progress bar implementation (#8012) 2023-02-22 11:57:38 -08:00
sort_utils.rs Use slices directly instead of &Vec (#10328) 2023-09-12 11:38:20 +08:00