nushell/crates/nu-command/src
Leon b12ffb8888
Fix sort-by, path join and size error arrows (#7199)
# Description
BEFORE:
```
〉ls | size
Error: nu:🐚:pipeline_mismatch (link)

  × Pipeline mismatch.
   ╭─[entry #22:1:1]
 1 │ ls | size
   ·      ──┬─
   ·        │╰── value originates from here
   ·        ╰── expected: string
   ╰────

〉ls | sort-by SIZE
Error: nu:🐚:column_not_found (link)

  × Cannot find column
   ╭─[entry #17:1:1]
 1 │ ls | sort-by SIZE
   ·      ───┬───
   ·         │╰── value originates here
   ·         ╰── cannot find column
   ╰────

〉[4kb] | path join 'b'
Error: nu:🐚:pipeline_mismatch (link)

  × Pipeline mismatch.
   ╭─[entry #6:1:1]
 1 │ [4kb] | path join 'b'
   · ──┬──
   ·   │╰── value originates from here
   ·   ╰── expected: string or record
   ╰────
```
AFTER:
```
〉ls | size
Error: nu:🐚:pipeline_mismatch (link)

  × Pipeline mismatch.
   ╭─[entry #1:1:1]
 1 │ ls | size
   · ─┬   ──┬─
   ·  │     ╰── expected: string
   ·  ╰── value originates from here
   ╰────

〉ls | get 0 | sort-by SIZE
Error: nu:🐚:column_not_found (link)

  × Cannot find column
   ╭─[entry #2:1:1]
 1 │ ls | get 0 | sort-by SIZE
   · ─┬           ───┬───
   ·  │              ╰── cannot find column 'SIZE'
   ·  ╰── value originates here
   ╰────

〉[4kb] | path join 'b'
Error: nu:🐚:pipeline_mismatch (link)

  × Pipeline mismatch.
   ╭─[entry #1:1:1]
 1 │ [4kb] | path join 'b'
   · ──┬──   ────┬────
   ·   │         ╰── expected: string or record
   ·   ╰── value originates from here
   ╰────

```

(Hey, anyone noticed that there's TWO wordings of "value originates from
here" in this codebase………?)

# User-Facing Changes

See above.

# Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace --features=extra -- -D warnings -D
clippy::unwrap_used -A clippy::needless_collect` to check that you're
using the standard code style
- `cargo test --workspace --features=extra` to check that all tests pass

# After Submitting

If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
2022-11-23 19:22:23 +13:00
..
bits add signature information when get help on one command (#7079) 2022-11-20 07:22:42 -06:00
bytes add signature information when get help on one command (#7079) 2022-11-20 07:22:42 -06:00
charting Split blocks and closures (#7075) 2022-11-10 21:21:49 +13:00
conversions add signature information when get help on one command (#7079) 2022-11-20 07:22:42 -06:00
core_commands Make external command substitution works friendly(like fish shell, trailing ending newlines) (#7156) 2022-11-23 16:51:57 +13:00
database Apply clippy fix (#7193) 2022-11-23 16:57:27 +13:00
dataframe Limited mutable variables (#7089) 2022-11-11 19:51:08 +13:00
date add signature information when get help on one command (#7079) 2022-11-20 07:22:42 -06:00
deprecated Rename all?, any? and empty? (#6464) 2022-09-05 16:41:06 +02:00
env Make external command substitution works friendly(like fish shell, trailing ending newlines) (#7156) 2022-11-23 16:51:57 +13:00
experimental Removes export env command (#6468) 2022-09-25 19:52:43 +03:00
filesystem Fix mv error message issues (arrows, Windows paths) (#7197) 2022-11-23 16:55:13 +13:00
filters Error on negative argument of first (#7186) 2022-11-23 17:04:28 +13:00
formats Stdout/Stderr redirection (#7185) 2022-11-23 07:26:13 +13:00
generators Remove --separator from seq date (#7096) 2022-11-11 20:16:44 +13:00
hash add signature information when get help on one command (#7079) 2022-11-20 07:22:42 -06:00
math add signature information when get help on one command (#7079) 2022-11-20 07:22:42 -06:00
misc Replace all instances of 'column path' in help messages with 'cell path' (#7063) 2022-11-09 21:49:11 -08:00
network Make external command substitution works friendly(like fish shell, trailing ending newlines) (#7156) 2022-11-23 16:51:57 +13:00
path Fix sort-by, path join and size error arrows (#7199) 2022-11-23 19:22:23 +13:00
platform add signature information when get help on one command (#7079) 2022-11-20 07:22:42 -06:00
random add signature information when get help on one command (#7079) 2022-11-20 07:22:42 -06:00
shells Refactor shell listing related code (#6262) 2022-08-08 06:31:24 -05:00
strings Fix sort-by, path join and size error arrows (#7199) 2022-11-23 19:22:23 +13:00
system Apply clippy fix (#7193) 2022-11-23 16:57:27 +13:00
viewers Apply clippy fix (#7193) 2022-11-23 16:57:27 +13:00
default_context.rs Feature cleanup (#7182) 2022-11-22 16:58:11 -08:00
example_test.rs Parser refactoring for improving pipelines (#7162) 2022-11-19 10:46:48 +13:00
input_handler.rs Replace all instances of 'column path' in help messages with 'cell path' (#7063) 2022-11-09 21:49:11 -08:00
lib.rs Feature cleanup (#7182) 2022-11-22 16:58:11 -08:00
sort_utils.rs Fix sort-by, path join and size error arrows (#7199) 2022-11-23 19:22:23 +13:00