90b65018b6
# Description Require that any value that looks like it might be a number (starts with a digit, or a '-' + digit, or a '+' + digits, or a special form float like `-inf`, `inf`, or `NaN`) must now be treated as a number-like value. Number-like syntax can only parse into number-like values. Number-like values include: durations, ints, floats, ranges, filesizes, binary data, etc. # User-Facing Changes BREAKING CHANGE BREAKING CHANGE BREAKING CHANGE BREAKING CHANGE BREAKING CHANGE BREAKING CHANGE BREAKING CHANGE BREAKING CHANGE Just making sure we see this for release notes 😅 This breaks any and all numberlike values that were treated as strings before. Example, we used to allow `3,` as a bare word. Anything like this would now require quotes or backticks to be treated as a string or bare word, respectively. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
98 lines
3.2 KiB
Rust
98 lines
3.2 KiB
Rust
use super::{list_shells, switch_shell, SwitchTo};
|
|
use nu_engine::CallExt;
|
|
use nu_protocol::ast::Call;
|
|
use nu_protocol::engine::{Command, EngineState, Stack};
|
|
use nu_protocol::{
|
|
Category, Example, PipelineData, ShellError, Signature, SyntaxShape, Type, Value,
|
|
};
|
|
|
|
/// Source a file for environment variables.
|
|
#[derive(Clone)]
|
|
pub struct GotoShell;
|
|
|
|
impl Command for GotoShell {
|
|
fn name(&self) -> &str {
|
|
"g"
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build("g")
|
|
.input_output_types(vec![
|
|
(Type::Nothing, Type::Nothing),
|
|
(Type::Nothing, Type::Table(vec![])),
|
|
])
|
|
.optional(
|
|
"shell_number",
|
|
SyntaxShape::OneOf(vec![SyntaxShape::Int, SyntaxShape::String]),
|
|
"shell number to change to",
|
|
)
|
|
.category(Category::Shells)
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Switch to a given shell, or list all shells if no given shell number."
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
_input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let new_shell: Option<Value> = call.opt(engine_state, stack, 0)?;
|
|
|
|
match new_shell {
|
|
Some(shell_span) => match &shell_span {
|
|
Value::String { val, span } => {
|
|
if val == "-" {
|
|
switch_shell(engine_state, stack, call, *span, SwitchTo::Last)
|
|
} else {
|
|
Err(ShellError::TypeMismatch {
|
|
err_message: "int or '-'".into(),
|
|
span: *span,
|
|
})
|
|
}
|
|
}
|
|
Value::Int { val, span } => switch_shell(
|
|
engine_state,
|
|
stack,
|
|
call,
|
|
*span,
|
|
SwitchTo::Nth(*val as usize),
|
|
),
|
|
_ => Err(ShellError::TypeMismatch {
|
|
err_message: "int or '-'".into(),
|
|
span: call.head,
|
|
}),
|
|
},
|
|
None => list_shells(engine_state, stack, call.head),
|
|
}
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![
|
|
Example {
|
|
description: "Lists all open shells",
|
|
example: r#"g"#,
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "Make two directories and enter new shells for them, use `g` to jump to the specific shell",
|
|
example: r#"mkdir foo bar; enter foo; enter ../bar; g 1"#,
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "Use `shells` to show all the opened shells and run `g 2` to jump to the third one",
|
|
example: r#"shells; g 2"#,
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "Make two directories and enter new shells for them, use `g -` to jump to the last used shell",
|
|
example: r#"mkdir foo bar; enter foo; enter ../bar; g -"#,
|
|
result: None,
|
|
},
|
|
]
|
|
}
|
|
}
|