nushell/crates/nu-command/src/system
Leon 9009f68e09
Tweak "Cannot convert {x} to a string argument" error in run_external (#7434)
# Description

The message arrow is altered to show the external command name in case
it wasn't obvious. (See example for an occasion where it is
non-obvious).

BEFORE:
```
〉else if (2mb) > 4mb
Error: nu:🐚:external_command (link)

  × External command failed
   ╭─[entry #35:1:1]
 1 │ else if (2mb) > 4mb
   ·           ─┬
   ·            ╰── Cannot convert filesize to a string
   ╰────
  help: All arguments to an external command need to be string-compatible
```
AFTER:
```
〉else if (2mb) > 4mb
Error: nu:🐚:external_command (link)

  × External command failed
   ╭─[entry #3:1:1]
 1 │ else if (2mb) > 4mb
   ·           ─┬
   ·            ╰── Cannot convert filesize to a string argument for 'else'
   ╰────
  help: All arguments to an external command need to be string-compatible

```
# User-Facing Changes

See above.

# Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass

# After Submitting

If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
2022-12-11 08:39:51 -08:00
..
benchmark.rs Improve empty pipelines (#7383) 2022-12-08 07:31:57 +13:00
complete.rs fix stdout hangged on (#6715) 2022-10-15 14:29:29 -05:00
exec.rs Make external command substitution works friendly(like fish shell, trailing ending newlines) (#7156) 2022-11-23 16:51:57 +13:00
mod.rs add a new command to query the registry on windows (#6670) 2022-10-07 13:54:36 -05:00
nu_check.rs Move from source to source-env (#6277) 2022-09-01 08:32:56 +12:00
ps.rs add a fair amount ofsearch terms (#6090) 2022-07-21 06:29:41 -05:00
registry_query.rs fix semicolon doesn't work for some commands (#7373) 2022-12-06 19:48:39 -08:00
run_external.rs Tweak "Cannot convert {x} to a string argument" error in run_external (#7434) 2022-12-11 08:39:51 -08:00
sys.rs fix sys info mem usage (#6607) 2022-09-23 11:47:52 -05:00
which_.rs Change how to identify custom comamnd (#6187) 2022-08-02 18:40:07 -05:00