# Description Final rework for https://github.com/nushell/nushell/issues/2741, after this one, we'll add for free HTTP PUT, PATCH, DELETE and HEAD. # User-Facing Changes We can now post data using HTTP GET. I add some examples in the output of `http get --help` to demonstrate this new behavior. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
200 lines
6.2 KiB
Rust
200 lines
6.2 KiB
Rust
use nu_engine::CallExt;
|
|
use nu_protocol::ast::Call;
|
|
use nu_protocol::engine::{Command, EngineState, Stack};
|
|
use nu_protocol::{
|
|
Category, Example, PipelineData, ShellError, Signature, SyntaxShape, Type, Value,
|
|
};
|
|
|
|
use crate::network::http::client::{
|
|
http_client, http_parse_url, request_add_authorization_header, request_add_custom_headers,
|
|
request_handle_response, request_set_body, request_set_timeout,
|
|
};
|
|
|
|
#[derive(Clone)]
|
|
pub struct SubCommand;
|
|
|
|
impl Command for SubCommand {
|
|
fn name(&self) -> &str {
|
|
"http get"
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build("http get")
|
|
.input_output_types(vec![(Type::Nothing, Type::Any)])
|
|
.required(
|
|
"URL",
|
|
SyntaxShape::String,
|
|
"the URL to fetch the contents from",
|
|
)
|
|
.named(
|
|
"user",
|
|
SyntaxShape::Any,
|
|
"the username when authenticating",
|
|
Some('u'),
|
|
)
|
|
.named(
|
|
"password",
|
|
SyntaxShape::Any,
|
|
"the password when authenticating",
|
|
Some('p'),
|
|
)
|
|
.named("data", SyntaxShape::Any, "the content to post", Some('d'))
|
|
.named(
|
|
"content-type",
|
|
SyntaxShape::Any,
|
|
"the MIME type of content to post",
|
|
Some('t'),
|
|
)
|
|
.named(
|
|
"content-length",
|
|
SyntaxShape::Any,
|
|
"the length of the content being posted",
|
|
Some('l'),
|
|
)
|
|
.named(
|
|
"max-time",
|
|
SyntaxShape::Int,
|
|
"timeout period in seconds",
|
|
Some('m'),
|
|
)
|
|
.named(
|
|
"headers",
|
|
SyntaxShape::Any,
|
|
"custom headers you want to add ",
|
|
Some('H'),
|
|
)
|
|
.switch(
|
|
"raw",
|
|
"fetch contents as text rather than a table",
|
|
Some('r'),
|
|
)
|
|
.switch(
|
|
"insecure",
|
|
"allow insecure server connections when using SSL",
|
|
Some('k'),
|
|
)
|
|
.filter()
|
|
.category(Category::Network)
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Fetch the contents from a URL."
|
|
}
|
|
|
|
fn extra_usage(&self) -> &str {
|
|
"Performs HTTP GET operation."
|
|
}
|
|
|
|
fn search_terms(&self) -> Vec<&str> {
|
|
vec![
|
|
"network", "fetch", "pull", "request", "download", "curl", "wget",
|
|
]
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
run_post(engine_state, stack, call, input)
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![
|
|
Example {
|
|
description: "http get content from example.com",
|
|
example: "http get https://www.example.com",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "http get content from example.com, with username and password",
|
|
example: "http get -u myuser -p mypass https://www.example.com",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "http get content from example.com, with custom header",
|
|
example: "http get -H [my-header-key my-header-value] https://www.example.com",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "http get from example.com, with body",
|
|
example: "http get -d 'body' https://www.example.com",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "http get from example.com, with JSON body",
|
|
example: "http get -t application/json -d { field: value } https://www.example.com",
|
|
result: None,
|
|
},
|
|
]
|
|
}
|
|
}
|
|
|
|
struct Arguments {
|
|
url: Value,
|
|
headers: Option<Value>,
|
|
data: Option<Value>,
|
|
content_type: Option<String>,
|
|
content_length: Option<String>,
|
|
raw: bool,
|
|
insecure: Option<bool>,
|
|
user: Option<String>,
|
|
password: Option<String>,
|
|
timeout: Option<Value>,
|
|
}
|
|
|
|
fn run_post(
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
_input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let args = Arguments {
|
|
url: call.req(engine_state, stack, 0)?,
|
|
headers: call.get_flag(engine_state, stack, "headers")?,
|
|
data: call.get_flag(engine_state, stack, "data")?,
|
|
content_type: call.get_flag(engine_state, stack, "content-type")?,
|
|
content_length: call.get_flag(engine_state, stack, "content-length")?,
|
|
raw: call.has_flag("raw"),
|
|
insecure: call.get_flag(engine_state, stack, "insecure")?,
|
|
user: call.get_flag(engine_state, stack, "user")?,
|
|
password: call.get_flag(engine_state, stack, "password")?,
|
|
timeout: call.get_flag(engine_state, stack, "timeout")?,
|
|
};
|
|
helper(engine_state, stack, call, args)
|
|
}
|
|
|
|
// Helper function that actually goes to retrieve the resource from the url given
|
|
// The Option<String> return a possible file extension which can be used in AutoConvert commands
|
|
fn helper(
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
args: Arguments,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let span = args.url.span()?;
|
|
let (requested_url, url) = http_parse_url(call, span, args.url)?;
|
|
|
|
let client = http_client(args.insecure.is_some());
|
|
let mut request = client.get(url);
|
|
|
|
if let Some(data) = args.data {
|
|
request = request_set_body(args.content_type, args.content_length, data, request)?;
|
|
}
|
|
request = request_set_timeout(args.timeout, request)?;
|
|
request = request_add_authorization_header(args.user, args.password, request);
|
|
request = request_add_custom_headers(args.headers, request)?;
|
|
|
|
let response = request.send().and_then(|r| r.error_for_status());
|
|
request_handle_response(
|
|
engine_state,
|
|
stack,
|
|
span,
|
|
&requested_url,
|
|
args.raw,
|
|
response,
|
|
)
|
|
}
|